xiaoxiang781216 commented on code in PR #7500: URL: https://github.com/apache/incubator-nuttx/pull/7500#discussion_r1010805492
########## boards/xtensa/esp32s3/esp32s3-devkit/src/Make.defs: ########## @@ -49,13 +49,12 @@ ifeq ($(CONFIG_LCD_ST7735),y) CSRCS += esp32s3_st7735.c endif -SCRIPTIN = $(SCRIPTDIR)$(DELIM)esp32s3.template.ld SCRIPTOUT = $(SCRIPTDIR)$(DELIM)esp32s3_out.ld .PHONY = context distclean -$(SCRIPTOUT): $(SCRIPTIN) $(CONFIGFILE) - $(Q) $(CC) -isystem $(TOPDIR)/include -C -P -x c -E $(SCRIPTIN) -o $@ +$(SCRIPTOUT): $(LDSCRIPT_TEMPLATE) $(CONFIGFILE) + $(Q) $(CC) -isystem $(TOPDIR)/include -I $(BOARD_COMMON_DIR)$(DELIM)scripts -C -P -x c -E $(LDSCRIPT_TEMPLATE) -o $@ Review Comment: don't need call $(CC) now, since arch/Makefile will do the same thing after https://github.com/apache/incubator-nuttx/pull/7208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
