Gary-Hobson commented on code in PR #7076:
URL: https://github.com/apache/incubator-nuttx/pull/7076#discussion_r1010609083
##########
drivers/segger/Make.defs:
##########
@@ -27,11 +27,11 @@ ifeq ($(CONFIG_SEGGER_RTT),y)
CFLAGS += -Wno-shadow -Wno-array-bounds
ifneq ($(CONFIG_SEGGER_RTT_SECTION),"")
- CFLAGS += ${shell $(DEFINE) "$(CC)"
SEGGER_RTT_SECTION=CONFIG_SEGGER_RTT_SECTION}
+ ${call DEFINE,CFLAGS,SEGGER_RTT_SECTION=CONFIG_SEGGER_RTT_SECTION}
Review Comment:
The custom function of the makefile cannot return a value, it can only
execute some commands, so this method cannot be used
I'm using variable concatenation now and it seems a bit better
https://stackoverflow.com/questions/29091370/how-can-i-pass-and-return-a-value-from-user-defined-function-in-makefile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
