[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #7436: arm: Added breakpoint in stack overflow trap.

[GitBox]

fjpanag commented on code in PR #7436:
URL: https://github.com/apache/incubator-nuttx/pull/7436#discussion_r1005915393


##########
arch/arm/src/armv8-m/arm_stackcheck.c:
##########
@@ -69,6 +69,12 @@ void __stack_overflow_trap(void)
 
   uint32_t regval;
 
+  regval = getreg32(NVIC_DHCSR);
+  if (regval & 0x01)

Review Comment:
   Bit 0 in `NVIC_DHCSR` indicates whether debugging is active.
   
   The `bkpt` instruction needs to be used only when debugging is enabled, or 
else a new fault is generated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org