gustavonihei commented on code in PR #7076:
URL: https://github.com/apache/incubator-nuttx/pull/7076#discussion_r1003437939
##########
drivers/segger/Make.defs:
##########
@@ -27,11 +27,11 @@ ifeq ($(CONFIG_SEGGER_RTT),y)
CFLAGS += -Wno-shadow -Wno-array-bounds
ifneq ($(CONFIG_SEGGER_RTT_SECTION),"")
- CFLAGS += ${shell $(DEFINE) "$(CC)"
SEGGER_RTT_SECTION=CONFIG_SEGGER_RTT_SECTION}
+ ${call DEFINE, CFLAGS, SEGGER_RTT_SECTION=CONFIG_SEGGER_RTT_SECTION}
Review Comment:
```suggestion
${call DEFINE,CFLAGS,SEGGER_RTT_SECTION=CONFIG_SEGGER_RTT_SECTION}
```
The `call` function arguments should not be preceded with whitespaces to
prevent unwanted effects:
See the "final caution" at the end of the documentation at
https://www.gnu.org/software/make/manual/html_node/Call-Function.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
