xiaoxiang781216 commented on PR #1358: URL: https://github.com/apache/incubator-nuttx-apps/pull/1358#issuecomment-1284250286
> > @masayuki2009 @pkarashchenko do you have more concern about this change? > > This is a case of counting semaphore with priority inheritance enabled. Yes, but ostest is very special one, because it verify the internal detail of OS implementation, and understanding the real behavior change between the enable and disable of priority inheritance. > We discussed this [apache/incubator-nuttx#6965 (comment)](https://github.com/apache/incubator-nuttx/pull/6965#discussion_r985285801) . So the question that I raise long time in the past comes again: Should priority inheritance be an option of semaphore or mutex only. In this case I'll rephrase it: Should we allow enabling of priority inheritance for non-binary semaphores. If yes, then we probably need to update many places in code with similar changes. I don't believe that the non-binary semaphore can work well with the priority inheritance in general. The priority inheritance is meaningful only when: 1. The semaphore has the binary value(0 or 1) 2. The semaphore is used as lock -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
