tmedicci commented on code in PR #7268: URL: https://github.com/apache/incubator-nuttx/pull/7268#discussion_r999510752
########## boards/xtensa/esp32/ttgo_t_display_esp32/configs/lvgl_lcd/defconfig: ########## @@ -42,7 +42,13 @@ CONFIG_LCD_ST7789_XOFFSET=53 CONFIG_LCD_ST7789_XRES=135 CONFIG_LCD_ST7789_YOFFSET=40 CONFIG_LCD_ST7789_YRES=240 -CONFIG_LV_HOR_RES=135 +CONFIG_LV_DEMO_WIDGETS_SLIDESHOW=y Review Comment: I think the slideshow example was removed, so that could be removed. ########## boards/xtensa/esp32/ttgo_t_display_esp32/configs/lvgl_fb/defconfig: ########## @@ -43,7 +43,13 @@ CONFIG_LCD_ST7789_XOFFSET=53 CONFIG_LCD_ST7789_XRES=135 CONFIG_LCD_ST7789_YOFFSET=40 CONFIG_LCD_ST7789_YRES=240 -CONFIG_LV_HOR_RES=135 +CONFIG_LV_DEMO_WIDGETS_SLIDESHOW=y Review Comment: I think the slideshow example was removed, so that could be removed. ########## boards/xtensa/esp32/ttgo_t_display_esp32/configs/lvgl_lcd/defconfig: ########## @@ -42,7 +42,13 @@ CONFIG_LCD_ST7789_XOFFSET=53 CONFIG_LCD_ST7789_XRES=135 CONFIG_LCD_ST7789_YOFFSET=40 CONFIG_LCD_ST7789_YRES=240 -CONFIG_LV_HOR_RES=135 +CONFIG_LV_DEMO_WIDGETS_SLIDESHOW=y Review Comment: Please, add (from `menuconfig`) the following flags: 1. `CONFIG_LV_FONT_MONTSERRAT_12` 2. `CONFIG_LV_FONT_MONTSERRAT_18` ########## boards/xtensa/esp32/ttgo_t_display_esp32/configs/lvgl_fb/defconfig: ########## @@ -43,7 +43,13 @@ CONFIG_LCD_ST7789_XOFFSET=53 CONFIG_LCD_ST7789_XRES=135 CONFIG_LCD_ST7789_YOFFSET=40 CONFIG_LCD_ST7789_YRES=240 -CONFIG_LV_HOR_RES=135 +CONFIG_LV_DEMO_WIDGETS_SLIDESHOW=y +CONFIG_LV_MEM_CUSTOM=y Review Comment: Please, add (from `menuconfig`) the following flags: 1. `CONFIG_LV_FONT_MONTSERRAT_12` 2. `CONFIG_LV_FONT_MONTSERRAT_18` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
