xiaoxiang781216 commented on code in PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#discussion_r995492501


##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -70,6 +70,9 @@ RUN mkdir -p $CARGO_HOME \
 
 CMD [ "/bin/bash" ]
 
+# Install dependence package
+RUN apt-get install -y libglib2.0-dev libpixman-1-dev ninja-build

Review Comment:
   merge to line 28



##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -78,6 +81,13 @@ FROM builder-base AS nuttx-toolchain-base
 RUN mkdir /tools
 WORKDIR /tools
 
+# Download and install qemu
+RUN mkdir qemu && \

Review Comment:
   move after line 70



##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -78,6 +81,13 @@ FROM builder-base AS nuttx-toolchain-base
 RUN mkdir /tools
 WORKDIR /tools
 
+# Download and install qemu
+RUN mkdir qemu && \
+  curl -s -L "https://download.qemu.org/qemu-7.1.0.tar.xz"; \
+  | tar -C qemu --strip-components 1 -xJ && \
+  cd qemu && ./configure && \
+  make && make install

Review Comment:
   need add copy rule in the last section



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to