anchao commented on PR #7284: URL: https://github.com/apache/incubator-nuttx/pull/7284#issuecomment-1275697599
> Anyway statement `defined(__NEWLIB__) || __NEWLIB__ < 4` seems to be wrong. If `__NEWLIB__` is not defined the `__NEWLIB__ < 4` will be evaluated and will produce compiler warning. So I think we should perform `__NEWLIB__` and `__NEWLIB_MINOR__` evaluation by preprocessor only if `__NEWLIB__` is defined. Thanks, please review this PR: https://github.com/apache/incubator-nuttx/pull/7289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org