xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r988540711
########## drivers/ipcc/ipcc_register.c: ########## @@ -176,7 +176,7 @@ int ipcc_register(FAR struct ipcc_lower_s *ipcc) /* nxsem_init can't really fail us if we provide it with valid params */ - nxsem_init(&priv->exclsem, 0, 1); + nxmutex_init(&priv->lock); nxsem_init(&priv->rxsem, 0, 0); nxsem_init(&priv->txsem, 0, 1); Review Comment: Since many places have the similar issue, let's do in the next patch: all nxsem_set_protocol will be removed, the default setting is good in all case. ########## drivers/ipcc/ipcc_register.c: ########## @@ -176,7 +176,7 @@ int ipcc_register(FAR struct ipcc_lower_s *ipcc) /* nxsem_init can't really fail us if we provide it with valid params */ - nxsem_init(&priv->exclsem, 0, 1); + nxmutex_init(&priv->lock); nxsem_init(&priv->rxsem, 0, 0); nxsem_init(&priv->txsem, 0, 1); Review Comment: Since many places have the similar issue, let's do in the next patch: all nxsem_set_protocol will be removed, the default setting is good in all cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
