xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r986038510
########## arch/arm/src/cxd56xx/cxd56_udmac.c: ########## @@ -238,7 +239,7 @@ void cxd56_udmainitialize(void) /* Initialize the channel list */ - nxsem_init(&g_dmac.exclsem, 0, 1); + nxmutex_init(&g_dmac.lock); nxsem_init(&g_dmac.chansem, 0, CXD56_DMA_NCHANNELS); Review Comment: The missing call isn't introduced by this PR, but it's the bug already exist in the origin code base. But, anyway I will change the runtime initialization to the static initializer as much as possible. So, the place which forget to call nxsem_set_protocol should be rare. The final goal(last patch) is that the whole code base doesn't call nxsem_set_protocol(all nxsem_set_protocol(SEM_PRIO_NONE) are removed too) anymore except nxmutex_t/nxrmutex_t/pthread_mutex_t. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
