xiaoxiang781216 commented on code in PR #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109#discussion_r985102090


##########
.github/workflows/build.yml:
##########
@@ -161,6 +161,7 @@ jobs:
             git config --global --add safe.directory 
/github/workspace/sources/apps
             cd sources/nuttx/tools/ci
             ./cibuild.sh -A -R -c testlist/${{matrix.boards}}.dat
+            #./cirun.sh -c -x testlist/${{matrix.boards}}.dat

Review Comment:
   revert



##########
boards/sim/sim/sim/configs/ci_ostest/defconfig:
##########
@@ -0,0 +1,76 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed 
.config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that 
includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set

Review Comment:
   can we integrate the test into ostest?



##########
tools/testbuild.sh:
##########
@@ -320,7 +320,11 @@ function refresh {
 
 function run {
   if [ ${RUN} -ne 0 ]; then
-    run_script="$path/run"
+    if [ -f $path/run ] && [ `echo ${path%/} |awk -F '/' '{print $NF}'` == 
"ci_ostest" ] ; then
+        run_script="$path/../../../../../../tools/ci/cirun.sh"
+    else
+        run_script="$path/run"

Review Comment:
   why not lunch the test with run script?



##########
tools/ci/testrun/README.md:
##########
@@ -0,0 +1,45 @@
+# Requirements
+- Python 3.6 or above
+- pexpect + minicom
+- pytest
+```bash
+sudo apt-get install minicom
+cd env
+pip3 install -r requirements.txt
+```
+# Docs
+[VelaOS Test](https://xiaomi.f.mioffice.cn/docs/dock4opHwhJkzV93W26ytiKCRgg#)

Review Comment:
   remove the internal link



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to