acassis commented on code in PR #7202:
URL: https://github.com/apache/incubator-nuttx/pull/7202#discussion_r982376578
##########
libs/libc/modlib/modlib_symbols.c:
##########
@@ -55,6 +56,11 @@ struct mod_exportinfo_s
FAR const struct symtab_s *symbol; /* Symbol info returned (if found) */
};
+typedef struct {
+ uint8_t *epName; /* Name of global symbol */
+ void *epAddr; /* Address of global symbol */
+} epTable_t;
+
Review Comment:
I think the issue is because the typedef makes it more difficult to know
what is that type (more opaque) and Hungarian notation (like used by FreeRTOS)
is not good visually. I could be wrong here, maybe others can confirm.
@xiaoxiang781216 @gregory-nutt @jerpelea ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
