anchao commented on code in PR #7165: URL: https://github.com/apache/incubator-nuttx/pull/7165#discussion_r978386945
########## arch/arm/src/common/arm_internal.h: ########## @@ -148,6 +148,24 @@ #define arm_switchcontext(saveregs, restoreregs) \ sys_call2(SYS_switch_context, (uintptr_t)saveregs, (uintptr_t)restoreregs); +/* Redefine the linker symbols as armlink style */ + +#ifdef CONFIG_ARM_TOOLCHAIN_ARMCLANG +# define _stext Image$$text$$Base +# define _etext Image$$text$$Limit +# define _eronly Image$$eronly$$Base +# define _sdata Image$$data$$Base +# define _edata Image$$data$$RW$$Limit +# define _sbss Image$$bss$$Base +# define _ebss Image$$bss$$ZI$$Limit +# define _stdata Image$$tdata$$Base +# define _etdata Image$$tdata$$Limit +# define _stbss Image$$tbss$$Base +# define _etbss Image$$tbss$$Limit +# define _snoinit Image$$noinit$$Base +# define _enoinit Image$$noinit$$Limit Review Comment: 1. The section name must be extern to avoid the compile warning. 2. The reason for the redefinition here is that the assembly code is also using this define: https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-a/arm_head.S#L723-L742 3. Defining on the CFLAGS will confuse developers to debugging the build commands, since too many symbols need to be redefined... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
