[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7160: arch: Change the linker generated symbols from uint32_t to uint8_t *

[GitBox]

xiaoxiang781216 commented on code in PR #7160:
URL: https://github.com/apache/incubator-nuttx/pull/7160#discussion_r977927681


##########
arch/arm/src/cxd56xx/cxd56_farapi.c:
##########
@@ -106,7 +106,7 @@ struct farmsg_s
  * Public Data
  ****************************************************************************/
 
-extern char _image_modlist_base[];
+extern uint8_t _image_modlist_base[];

Review Comment:
   Done.



##########
arch/arm/src/cxd56xx/cxd56_farapi.c:
##########
@@ -230,7 +230,7 @@ void farapi_main(int id, void *arg, struct modulelist_s 
*mlist)
   api = &msg.u.api;
 
   msg.cpuid      = getreg32(CPU_ID);
-  msg.modid      = mlist - (struct modulelist_s *)&_image_modlist_base;
+  msg.modid      = mlist - (struct modulelist_s *)_image_modlist_base;

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org