pkarashchenko commented on code in PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#discussion_r964541655
########## libs/libc/math/lib_round.c: ########## @@ -34,6 +34,11 @@ #ifdef CONFIG_HAVE_DOUBLE double round(double x) { + if (isinf(x) || isnan(x)) + { + return (x); + } + double f = modf(x, &x); Review Comment: please address this. It is C89 incompliant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org