pkarashchenko commented on code in PR #7020:
URL: https://github.com/apache/incubator-nuttx/pull/7020#discussion_r964468069
##########
net/netdev/netdev_ioctl.c:
##########
@@ -616,6 +616,70 @@ static FAR struct net_driver_s *netdev_ifr_dev(FAR struct
ifreq *req)
return NULL;
}
+/****************************************************************************
+ * Name: net_ioctl_ifreq_arglen
+ *
+ * Description:
+ * Calculate the ioctl argument buffer length of ifreq.
+ *
+ * Input Parameters:
+ *
+ * cmd The ioctl command
+ *
+ * Returned Value:
+ * The argument buffer length, or error code.
+ *
+ ****************************************************************************/
+
+static ssize_t net_ioctl_ifreq_arglen(int cmd)
+{
+ switch (cmd)
+ {
+ case SIOCGIFADDR:
+ case SIOCSIFADDR:
+ case SIOCGIFDSTADDR:
+ case SIOCSIFDSTADDR:
+ case SIOCGIFBRDADDR:
+ case SIOCSIFBRDADDR:
+ case SIOCGIFNETMASK:
+ case SIOCSIFNETMASK:
+ case SIOCGIFMTU:
+ case SIOCGIFHWADDR:
+ case SIOCSIFHWADDR:
+ case SIOCDIFADDR:
+ case SIOCGIFCOUNT:
+ case SIOCSIFFLAGS:
+ case SIOCGIFFLAGS:
+ case SIOCMIINOTIFY:
+ case SIOCGMIIPHY:
+ case SIOCGMIIREG:
+ case SIOCSMIIREG:
+ case SIOCGCANBITRATE:
+ case SIOCSCANBITRATE:
+ case SIOCACANEXTFILTER:
+ case SIOCDCANEXTFILTER:
+ case SIOCACANSTDFILTER:
+ case SIOCDCANSTDFILTER:
+ case SIOCGIFNAME:
+ case SIOCGIFINDEX:
+ return sizeof(struct ifreq);
+
+ case SIOCGLIFADDR:
+ case SIOCSLIFADDR:
+ case SIOCGLIFDSTADDR:
+ case SIOCSLIFDSTADDR:
+ case SIOCGLIFBRDADDR:
+ case SIOCSLIFBRDADDR:
+ case SIOCGLIFNETMASK:
+ case SIOCSLIFNETMASK:
+ case SIOCGLIFMTU:
+ case SIOCIFAUTOCONF:
+ return sizeof(struct lifreq);
+ }
Review Comment:
could you please add `default: break;` to make some static code analyzers
happy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
