fjpanag commented on PR #6956: URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1236984317
@anchao Sorry I should have explained better. I have applied this patch, but I have deliberately commented out your last fix checking the reference count. I did this, so I can still have the assertion fail, and examine this issue better. I wanted to understand the path the code is taking, as I believe it is not working as we think. You identified [this](https://github.com/apache/incubator-nuttx/blob/master/net/tcp/tcp_conn.c#L638-L676) as the root cause of the failed assertion. According to my analysis, this is wrong. The two do not seem correlated. Or if they are, this is not the only problem. So this fix may be wrong, as it tries to solve an issue that maybe it is not there. I am afraid that this fix may just mask the actual problem, or cause a leak. I would like us to positively identify the root cause, before applying any changes. Also, the issue with threads getting stuck during `connect()` appears to be fairly common to us. It happens in all of our devices, a few times per day. I have a tendency to believe that these two are correlated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
