xiaoxiang781216 commented on code in PR #6974: URL: https://github.com/apache/incubator-nuttx/pull/6974#discussion_r959901903
########## net/usrsock/usrsock_ioctl.c: ########## @@ -233,6 +234,11 @@ int usrsock_ioctl(FAR struct socket *psock, int cmd, FAR void *arg, errout_unlock: net_unlock(); + if (ret == OK && cmd == FIONBIO) Review Comment: Since the usrsock server always put the socket in nonblocking mode, should we return -ENOTTY at the beginning? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
