XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r945405336
########## include/nuttx/mtd/configdata.h: ########## @@ -120,6 +120,27 @@ extern "C" struct mtd_dev_s; int mtdconfig_register(FAR struct mtd_dev_s *mtd); +/**************************************************************************** + * Name: mtdnvs_register + * + * Description: + * This function binds an instance of an MTD device to the /dev/config + * device. + * + * When this function is called, the MTD device pass in should already + * be initialized appropriately to access the physical device or partition. + * + * Input Parameters: + * mtd - Pointer to the MTD device to bind with the /dev/config device + * + * Returned Value: + * Zero on success; a negated errno value on failure. + + * + ****************************************************************************/ + +int mtdnvs_register(FAR struct mtd_dev_s *mtd); Review Comment: Isn't it confusing to use the same function name? After all, nvs is a different method. I don't see the need to make them look the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
