pkarashchenko commented on PR #6816:
URL: https://github.com/apache/incubator-nuttx/pull/6816#issuecomment-1210919929
I do not have a strong opinion on this. The PR description states "since
l2cc_invalidate_all already do the protection" ("callee" direction), but
discussion goes into "caller" direction, so that is a bit confusing.
I think that critical section here is done to ensure that invalidation
sequence is not interrupted, so removing of a critical section allows an
interruption, so calling it from a critical section becomes a caller
responsibility. I think this is what @hartmannathan is talking about and it
sounds reasonable to at least specify this in comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
