onegray commented on code in PR #6695:
URL: https://github.com/apache/incubator-nuttx/pull/6695#discussion_r928952897
##########
wireless/bluetooth/bt_hcicore.c:
##########
@@ -1861,7 +1848,6 @@ int bt_hci_cmd_send_sync(uint16_t opcode, FAR struct
bt_buf_s *buf,
bt_buf_release(buf->u.hci.sync);
}
- bt_buf_release(buf);
Review Comment:
This `release` was in the correct place for a 'taking ownership' function.
But there is also a missing `addref` when we make a strong ref pointer when
passing the buffer to `g_btdev.tx_queue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
