lupyuen opened a new issue, #6642:
URL: https://github.com/apache/incubator-nuttx/issues/6642

   `SNIOC_SET_INTERVAL` is defined twice in 
[sensors/ioctl.h](https://github.com/apache/incubator-nuttx/blob/master/include/nuttx/sensors/ioctl.h#L174-L175)
 with different values.
   
   `SNIOC_SET_INTERVAL` is first defined in [ioctl.h line 
175](https://github.com/apache/incubator-nuttx/blob/master/include/nuttx/sensors/ioctl.h#L174-L175):
   
   ```c
   /* SNIOC_READ_CONVERT_DATA */                     /* Arg: struct 
scd30_conv_data_s* */
   #define SNIOC_SET_INTERVAL         _SNIOC(0x0054) /* Arg: uint16_t value 
(seconds) */
   ```
   
   Then again in [ioctl.h line 
251](https://github.com/apache/incubator-nuttx/blob/master/include/nuttx/sensors/ioctl.h#L246-L251)
 with a different value:
   
   ```c
   /* Command:      SNIOC_SET_INTERVAL
    * Description:  Set interval between samples
    * Argument:     This is the interval pointer, in microseconds
    */
   #define SNIOC_SET_INTERVAL         _SNIOC(0x0081)
   ```
   
   Perhaps the first definition should be removed?
   
   I discovered this when [converting NuttX Sensor Test to 
Zig](https://github.com/lupyuen/visual-zig-nuttx), and Zig incorrectly used the 
first value (instead of the correct second value). Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to