ALTracer opened a new pull request, #6640: URL: https://github.com/apache/incubator-nuttx/pull/6640
## Summary Rename the SLIP options to be consistent with the driver source. 2d7c072723902aa763d3851f6399c39cbb1851fe deleted them from drivers/net/Kconfig as "duplicates" despite them having slightly different names (SLIP_STACKSIZE vs NET_SLIP_STACKSIZE). See https://github.com/apache/incubator-nuttx/blob/b10658653ba4567191ffcd98e0e4c1a3df3f0db0/drivers/net/slip.c#L68 ```c #ifndef CONFIG_NET_SLIP_STACKSIZE # define CONFIG_NET_SLIP_STACKSIZE 2048 #endif #ifndef CONFIG_NET_SLIP_DEFPRIO # define CONFIG_NET_SLIP_DEFPRIO 128 #endif ``` but https://github.com/apache/incubator-nuttx/blob/b10658653ba4567191ffcd98e0e4c1a3df3f0db0/net/Kconfig#L207 This reserves 2048 bytes by default (not even CONFIG_DEFAULT_TASK_SIZE) for each of 2 threads, even though I see typically only 300-400 bytes used on armv6-m UART 115200 link responding to 50..250-byte ICMP pings. Make kthread stacksize configurable again. I don't feel like these options truly belonged in drivers/net/Kconfig with external MACs, either. ## Impact Boards using SLIP. Currently in-tree only sim:tcpblaster and olimex-lpc1766stk:slip-httpd. ## Testing nucleo-h743zi2: builds without errors. Milandr mdr32: builds and runs with reduced stack footprint (rxslip+txslip 4k->1.5k). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
