xiaoxiang781216 commented on code in PR #6605:
URL: https://github.com/apache/incubator-nuttx/pull/6605#discussion_r922685607
##########
fs/mount/fs_procfs_mount.c:
##########
@@ -248,6 +248,10 @@ static int blocks_entry(FAR const char *mountpoint,
if (!info->header)
{
+#if defined(CONFIG_HAVE_LONG_LONG) && !defined(CONFIG_LIBC_LONG_LONG)
+ finfo("long long is enabled, but libc does not support it;\n"
Review Comment:
There are many places which call [s]printf with [u]int64_t, so it isn't good
to check it only here or spread the check around the whole code base. The good
fix is do the check inside the core of printf like
https://github.com/apache/incubator-nuttx/pull/6613 which should address all
issue you concern about:
1. Output the correct value if the value isn't bigger than [U]LONG_MAX
2. Assert if the value is out of range.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
