xiaoxiang781216 commented on PR #6613: URL: https://github.com/apache/incubator-nuttx/pull/6613#issuecomment-1185295923
> > > The original complaint was that there is a need to perform computation in long long, but disable long long printing in LIBC. > > > > > > Yes, and since now it can print correctly even when LIBC_LONG_LONG is not enabled and will increase only 192 bytes, this seems a nice solution! @ALTracer do you agree? I know you spent time implementing other fixes, but this solution is easier and solves the original "df -h" issue. > > This PR is better than #6606, but I still have questions. > > @xiaoxiang781216 Does printf now parse ull as ul? Yes, it will handle both. > What if ull argument is > ULONG_MAX? Who should deal with overflows -- calling site or printf (with debug warnings before casting / consuming va_arg)? it's simply discard the high 32bit, which mean the output is correct if value is less/equal than ULONG_MAX, but wrong if great than ULONG_MAX. > > I'm fine with code size like that. Apparently, it's coming only from libc internals now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
