xiaoxiang781216 commented on code in PR #6607:
URL: https://github.com/apache/incubator-nuttx/pull/6607#discussion_r921377507


##########
libs/libc/stdio/Kconfig:
##########
@@ -53,7 +53,7 @@ config NUNGET_CHARS
 
 config LIBC_FLOATINGPOINT
        bool "Enable floating point in printf"
-       default n
+       default !DEFAULT_SMALL && ARCH_FPU

Review Comment:
   > Why we rely on `ARCH_FPU`? The `LIBC_FLOATINGPOINT` does not have anything 
about hard vs soft FPU. Or for archs with `ARCH_FPU` the code size increase is 
low?
   
   I assume that it's rare to use float point if the hardware doesn't support 
FPU directly. So, LIBC_FLOATINGPOINT is disabled by default in this case, but 
user can enable it if they really want to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to