pkarashchenko commented on code in PR #6478:
URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902552374
##########
boards/Kconfig:
##########
@@ -1575,6 +1575,15 @@ config ARCH_BOARD_SABRE_6QUAD
This options selects support for NuttX on the NXP/Freescale
Sabre
board featuring the iMX 6Quad CPU.
+
+config ARCH_BOARD_QEMU_A53
Review Comment:
Please revert file permissions
##########
boards/arm64/qemu/qemu-a53/scripts/Make.defs:
##########
@@ -0,0 +1,51 @@
+############################################################################
+# boards/arm64/qemu/qemu-a53/scripts/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(TOPDIR)/.config
+include $(TOPDIR)/tools/Config.mk
+include $(TOPDIR)/arch/arm64/src/Toolchain.defs
+
+LDSCRIPT = dramboot.ld
+
+ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
+
+
+
+
Review Comment:
I think some of the newlines can be removed
##########
arch/arm64/src/common/arm64_gic.h:
##########
@@ -0,0 +1,317 @@
+/****************************************************************************
+ * arch/arm64/src/common/arm64_gic.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ *
+ ****************************************************************************/
+
+#ifndef __ARCH_ARM64_SRC_COMMON_ARM64_GICV3_H
+#define __ARCH_ARM64_SRC_COMMON_ARM64_GICV3_H
Review Comment:
Please either rename file to `arm64_gicv3.h` or change the macro
##########
tools/ci/testlist/other.dat:
##########
@@ -20,3 +20,7 @@
# Sparc-gaisler-elf toolchain doesn't provide macOS binaries
/sparc
-xx3823:nsh
+
Review Comment:
Please revert file permissions
##########
arch/Kconfig:
##########
@@ -22,6 +22,20 @@ config ARCH_ARM
---help---
The ARM architectures
+config ARCH_ARM64
Review Comment:
Please revert file permissions
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -87,6 +87,15 @@ RUN mkdir gcc-arm-none-eabi && \
curl -s -L
"https://developer.arm.com/-/media/Files/downloads/gnu-rm/10.3-2021.10/gcc-arm-none-eabi-10.3-2021.10-x86_64-linux.tar.bz2";
\
| tar -C gcc-arm-none-eabi --strip-components 1 -xj
+###############################################################################
Review Comment:
Please revert file permissions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
