xiaoxiang781216 commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r878682094
########## sched/task/exit.c: ########## @@ -70,7 +68,7 @@ void _exit(int status) * ****************************************************************************/ -void exit(int status) +void nx_exit(int status) Review Comment: If so, we can reorder the code in _exit to correct the sequence. It can't resolve by introducing nx_exit. So, I would suggest that: Remove nx_exit Make exit as a normal libc function Make _exit as the kernel function atexit related function look in a good shape, the next step is simple now: Create a new patch to remove the kernel side atexit and enable libc's version Remove the exit callback from _exit The last step is moving file stream flush/close to the userspace. The last work is my TODO list, actually I have a draft patch in my local branch for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
