xiaoxiang781216 commented on code in PR #6305: URL: https://github.com/apache/incubator-nuttx/pull/6305#discussion_r878306656
########## mm/mm_heap/mm_malloc.c: ########## @@ -244,15 +244,18 @@ FAR void *mm_malloc(FAR struct mm_heap_s *heap, size_t size) #ifdef CONFIG_DEBUG_MM else { +#ifdef CONFIG_MM_DUMP_ON_FAILURE struct mallinfo minfo; +#endif mwarn("WARNING: Allocation failed, size %zu\n", alignsize); +#ifdef CONFIG_MM_DUMP_ON_FAILURE mm_mallinfo(heap, &minfo); mwarn("Total:%d, used:%d, free:%d, largest:%d, nused:%d, nfree:%d\n", minfo.arena, minfo.uordblks, minfo.fordblks, minfo.mxordblk, minfo.aordblks, minfo.ordblks); mm_memdump(heap, -1); - DEBUGASSERT(false); +#endif Review Comment: but DEBUGASSERT get removed? it's very useful to generate the backtrace when debugging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org