gustavonihei commented on code in PR #6304:
URL: https://github.com/apache/incubator-nuttx/pull/6304#discussion_r878130883
##########
arch/risc-v/src/mpfs/hardware/mpfs_ihc.h:
##########
@@ -274,57 +274,19 @@
#define IHC_MAX_MESSAGE_SIZE 4
-typedef union ihca_ip_int_en_t_
-{
- uint32_t int_en;
- struct
- {
- uint32_t mp_h0_en : 1;
- uint32_t ack_h0_en : 1;
- uint32_t mp_h1_en : 1;
- uint32_t ack_h1_en : 1;
- uint32_t mp_h2_en : 1;
- uint32_t ack_h2_en : 1;
- uint32_t mp_h3_en : 1;
- uint32_t ack_h3_en : 1;
- uint32_t mp_h4_en : 1;
- uint32_t ack_h4_en : 1;
- uint32_t reserved : 22;
- } bitfield;
-} ihca_ip_int_en_t;
-
-typedef union ihca_ip_msg_avail_stat_t_
-{
- uint32_t msg_avail;
- struct
- {
- uint32_t mp_h0 : 1;
- uint32_t ack_h0 : 1;
- uint32_t mp_h1 : 1;
- uint32_t ack_h1 : 1;
- uint32_t mp_h2 : 1;
- uint32_t ack_h2 : 1;
- uint32_t mp_h3 : 1;
- uint32_t ack_h3 : 1;
- uint32_t mp_h4 : 1;
- uint32_t ack_h4 : 1;
- uint32_t reserved : 22;
- } bitfield;
-} ihca_ip_msg_avail_stat_t;
-
-typedef union
+#define SBI_EXT_IHC_CTX_INIT 0
+#define SBI_EXT_IHC_SEND 1
+#define SBI_EXT_IHC_RECEIVE 2
+
+typedef enum
Review Comment:
```suggestion
enum ihc_channel_e
```
NuttX coding standard forbids the declaration of unnamed enums and structs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
