acassis commented on code in PR #6295:
URL: https://github.com/apache/incubator-nuttx/pull/6295#discussion_r875999235


##########
arch/arm/src/samv7/sam_progmem.c:
##########
@@ -202,9 +202,9 @@ void sam_progmem_initialize(void)
 {
   uint32_t regval;
 
-  /* Set flash access mode to 128bit and wait status to 4 */
+  /* Flash access mode is 128bit always so configure wait states to 6 */
 
-  sam_eefc_initaccess(SAM_EFC_ACCESS_MODE_128, 4);
+  sam_eefc_initaccess(6);

Review Comment:
   Suggestion: define a symbol with flash wait states equal 6 instead of 
hardcoding it in two places



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to