[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

[GitBox]

pussuw commented on code in PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r870695648


##########
sched/task/exit.c:
##########
@@ -108,3 +106,8 @@ void exit(int status)
 
   _exit(status);
 }
+
+void exit(int status)

Review Comment:
   It is this one I think:
    ```
   
====================================================================================
   Configuration/Tool: amber/hello
   
------------------------------------------------------------------------------------
     Cleaning...
     Configuring...
     Building NuttX...
   /usr/lib/gcc/avr/5.4.0/avr51/libgcc.a(_exit.o): In function `_exit':
   (.fini9+0x0): multiple definition of `_exit'
   
/github/workspace/sources/nuttx/staging/libsched.a(exit.o):exit.c:(.text+0x0): 
first defined here
   make[1]: *** [Makefile:94: nuttx] Error 1
   make: *** [tools/Unix.mk:509: nuttx] Error 2
   make: Target 'all' not remade because of errors.
   /github/workspace/sources/nuttx/tools/testbuild.sh: line 257: 
/github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or 
directory
     Normalize amber/hello
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org