pussuw commented on PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1121349667
> > > @pussuw I think we can do the huge change into the follow patch one by one: > > > ``` > > > 1. Move tg_exit from task_group_s to task_info_s > > > > > > 2. Move the related functions from sched/ to libs/libc > > > > > > 3. Remove the unused config from defconfig > > > ``` > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > BTW, it's better to create a new PR for merging atexit/on_exit/cxa_atexit, it's not good to mix the different change into one huge patch. > > > > > > I agree this PR is too big, I will split it and do some clean up. It will be quite difficult to keep everything functional though between the different patches. > > Is there some way to tell that PR a "Depends-On" PR b in Github ? > > No, so I would suggest you create a new PR do the clean up first without moving any struct or function to userspace: > > 1. Merge atexit/on_exit/cxa_exit into one > > 2. Remove the unused config > > > Once the change get merged. You can create a new PR: > > 1. Move the struct to userspace > > 2. Move the function to libs/libc > > > I think that four patch put in two PR is enough. Yes I'll figure it out tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
