pkarashchenko commented on code in PR #6092:
URL: https://github.com/apache/incubator-nuttx/pull/6092#discussion_r856893416
##########
arch/arm/src/imxrt/imxrt_adc.h:
##########
@@ -67,8 +67,8 @@ extern "C"
****************************************************************************/
#ifdef CONFIG_IMXRT_ADC
-FAR struct adc_dev_s *imxrt_adcinitialize(int intf,
- FAR const uint8_t *chanlist,
+struct adc_dev_s *imxrt_adcinitialize(int intf,
+ const uint8_t *chanlist,
int nchannels);
Review Comment:
```suggestion
struct adc_dev_s *imxrt_adcinitialize(int intf,
const uint8_t *chanlist,
int nchannels);
```
##########
arch/arm/src/imxrt/imxrt_flexpwm.c:
##########
@@ -87,28 +87,28 @@ struct imxrt_flexpwm_module_s
struct imxrt_flexpwm_s
{
const struct pwm_ops_s *ops; /* PWM operations */
- FAR struct imxrt_flexpwm_module_s *modules;
+ struct imxrt_flexpwm_module_s *modules;
uint8_t modules_num; /* Number of modules */
uint32_t frequency; /* PWM frequency */
uint32_t base; /* Base address of peripheral register */
};
/* PWM driver methods */
-static int pwm_setup(FAR struct pwm_lowerhalf_s *dev);
-static int pwm_shutdown(FAR struct pwm_lowerhalf_s *dev);
-static int pwm_start(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info);
-static int pwm_stop(FAR struct pwm_lowerhalf_s *dev);
-static int pwm_ioctl(FAR struct pwm_lowerhalf_s *dev,
+static int pwm_setup(struct pwm_lowerhalf_s *dev);
+static int pwm_shutdown(struct pwm_lowerhalf_s *dev);
+static int pwm_start(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info);
+static int pwm_stop(struct pwm_lowerhalf_s *dev);
+static int pwm_ioctl(struct pwm_lowerhalf_s *dev,
int cmd, unsigned long arg);
/* Helper functions */
-static int pwm_set_output(FAR struct pwm_lowerhalf_s *dev, uint8_t channel,
+static int pwm_set_output(struct pwm_lowerhalf_s *dev, uint8_t channel,
ub16_t duty);
Review Comment:
```suggestion
static int pwm_set_output(struct pwm_lowerhalf_s *dev, uint8_t channel,
ub16_t duty);
```
##########
arch/arm/src/imxrt/imxrt_usbdev.c:
##########
@@ -2114,11 +2114,11 @@ static int imxrt_usbinterrupt(int irq, FAR void
*context, FAR void *arg)
*
****************************************************************************/
-static int imxrt_epconfigure(FAR struct usbdev_ep_s *ep,
- FAR const struct usb_epdesc_s *desc,
+static int imxrt_epconfigure(struct usbdev_ep_s *ep,
+ const struct usb_epdesc_s *desc,
bool last)
Review Comment:
```suggestion
static int imxrt_epconfigure(struct usbdev_ep_s *ep,
const struct usb_epdesc_s *desc,
bool last)
```
##########
arch/arm/src/imxrt/imxrt_flexpwm.c:
##########
@@ -635,10 +635,10 @@ static int pwm_change_freq(FAR struct pwm_lowerhalf_s
*dev,
*
****************************************************************************/
-static int pwm_set_output(FAR struct pwm_lowerhalf_s *dev, uint8_t channel,
+static int pwm_set_output(struct pwm_lowerhalf_s *dev, uint8_t channel,
ub16_t duty)
Review Comment:
```suggestion
static int pwm_set_output(struct pwm_lowerhalf_s *dev, uint8_t channel,
ub16_t duty)
```
##########
arch/arm/src/kinetis/kinetis_sdhc.c:
##########
@@ -2627,7 +2627,7 @@ static void kinetis_callbackenable(FAR struct sdio_dev_s
*dev,
*
****************************************************************************/
-static int kinetis_registercallback(FAR struct sdio_dev_s *dev,
+static int kinetis_registercallback(struct sdio_dev_s *dev,
worker_t callback, void *arg)
Review Comment:
```suggestion
static int kinetis_registercallback(struct sdio_dev_s *dev,
worker_t callback, void *arg)
```
##########
arch/arm/src/kinetis/kinetis_usbhshost.c:
##########
@@ -3707,8 +3707,8 @@ static int kinetis_wait(FAR struct usbhost_connection_s
*conn,
*
****************************************************************************/
-static int kinetis_rh_enumerate(FAR struct usbhost_connection_s *conn,
- FAR struct usbhost_hubport_s *hport)
+static int kinetis_rh_enumerate(struct usbhost_connection_s *conn,
+ struct usbhost_hubport_s *hport)
Review Comment:
```suggestion
static int kinetis_rh_enumerate(struct usbhost_connection_s *conn,
struct usbhost_hubport_s *hport)
```
##########
arch/arm/src/kinetis/kinetis_usbhshost.c:
##########
@@ -3993,7 +3993,7 @@ static int kinetis_enumerate(FAR struct
usbhost_connection_s *conn,
*
****************************************************************************/
-static int kinetis_ep0configure(FAR struct usbhost_driver_s *drvr,
+static int kinetis_ep0configure(struct usbhost_driver_s *drvr,
usbhost_ep_t ep0, uint8_t funcaddr,
uint8_t speed, uint16_t maxpacketsize)
Review Comment:
```suggestion
static int kinetis_ep0configure(struct usbhost_driver_s *drvr,
usbhost_ep_t ep0, uint8_t funcaddr,
uint8_t speed, uint16_t maxpacketsize)
```
##########
arch/arm/src/kinetis/kinetis_usbhshost.c:
##########
@@ -4933,8 +4933,8 @@ static int kinetis_connect(FAR struct usbhost_driver_s
*drvr,
*
****************************************************************************/
-static void kinetis_disconnect(FAR struct usbhost_driver_s *drvr,
- FAR struct usbhost_hubport_s *hport)
+static void kinetis_disconnect(struct usbhost_driver_s *drvr,
+ struct usbhost_hubport_s *hport)
Review Comment:
```suggestion
static void kinetis_disconnect(struct usbhost_driver_s *drvr,
struct usbhost_hubport_s *hport)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_lcd.c:
##########
@@ -203,8 +203,8 @@ static int lpc17_40_getvideoinfo(FAR struct fb_vtable_s
*vtable,
* Name: lpc17_40_getplaneinfo
****************************************************************************/
-static int lpc17_40_getplaneinfo(FAR struct fb_vtable_s *vtable, int planeno,
- FAR struct fb_planeinfo_s *pinfo)
+static int lpc17_40_getplaneinfo(struct fb_vtable_s *vtable, int planeno,
+ struct fb_planeinfo_s *pinfo)
Review Comment:
```suggestion
static int lpc17_40_getplaneinfo(struct fb_vtable_s *vtable, int planeno,
struct fb_planeinfo_s *pinfo)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_mcpwm.c:
##########
@@ -103,26 +103,26 @@ static void mcpwm_putreg(struct lpc17_40_mcpwmtimer_s
*priv,
#ifdef CONFIG_DEBUG_PWM_INFO
static void mcpwm_dumpregs(struct lpc17_40_mcpwmtimer_s *priv,
- FAR const char *msg);
+ const char *msg);
#else
# define mcpwm_dumpregs(priv,msg)
#endif
/* Timer management */
-static int mcpwm_timer(FAR struct lpc17_40_mcpwmtimer_s *priv,
- FAR const struct pwm_info_s *info);
+static int mcpwm_timer(struct lpc17_40_mcpwmtimer_s *priv,
+ const struct pwm_info_s *info);
Review Comment:
```suggestion
static int mcpwm_timer(struct lpc17_40_mcpwmtimer_s *priv,
const struct pwm_info_s *info);
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_mcpwm.c:
##########
@@ -103,26 +103,26 @@ static void mcpwm_putreg(struct lpc17_40_mcpwmtimer_s
*priv,
#ifdef CONFIG_DEBUG_PWM_INFO
static void mcpwm_dumpregs(struct lpc17_40_mcpwmtimer_s *priv,
- FAR const char *msg);
+ const char *msg);
#else
# define mcpwm_dumpregs(priv,msg)
#endif
/* Timer management */
-static int mcpwm_timer(FAR struct lpc17_40_mcpwmtimer_s *priv,
- FAR const struct pwm_info_s *info);
+static int mcpwm_timer(struct lpc17_40_mcpwmtimer_s *priv,
+ const struct pwm_info_s *info);
/* PWM driver methods */
-static int mcpwm_setup(FAR struct pwm_lowerhalf_s *dev);
-static int mcpwm_shutdown(FAR struct pwm_lowerhalf_s *dev);
+static int mcpwm_setup(struct pwm_lowerhalf_s *dev);
+static int mcpwm_shutdown(struct pwm_lowerhalf_s *dev);
-static int mcpwm_start(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info);
+static int mcpwm_start(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info);
Review Comment:
```suggestion
static int mcpwm_start(struct pwm_lowerhalf_s *dev,
const struct pwm_info_s *info);
```
##########
arch/arm/src/imxrt/imxrt_wdog.c:
##########
@@ -297,11 +297,11 @@ static int imxrt_wdog_getstatus(FAR struct
watchdog_lowerhalf_s *lower,
*
****************************************************************************/
-static int imxrt_wdog_settimeout(FAR struct watchdog_lowerhalf_s *lower,
+static int imxrt_wdog_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout)
Review Comment:
```suggestion
static int imxrt_wdog_settimeout(struct watchdog_lowerhalf_s *lower,
uint32_t timeout)
```
##########
arch/arm/src/imxrt/imxrt_flexpwm.c:
##########
@@ -555,10 +555,10 @@ static struct imxrt_flexpwm_s g_pwm4 =
*
****************************************************************************/
-static int pwm_change_freq(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info, uint8_t channel)
+static int pwm_change_freq(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info, uint8_t channel)
Review Comment:
```suggestion
static int pwm_change_freq(struct pwm_lowerhalf_s *dev,
const struct pwm_info_s *info,
uint8_t channel)
```
##########
arch/arm/src/imxrt/imxrt_ehci.c:
##########
@@ -4116,7 +4116,7 @@ static int imxrt_alloc(FAR struct usbhost_driver_s *drvr,
* multiple of the cache line size in length.
*/
- *buffer = (FAR uint8_t *)kmm_memalign(ARMV7M_DCACHE_LINESIZE,
+ *buffer = (uint8_t *)kmm_memalign(ARMV7M_DCACHE_LINESIZE,
IMXRT_EHCI_BUFSIZE);
Review Comment:
```suggestion
IMXRT_EHCI_BUFSIZE);
```
##########
arch/arm/src/kinetis/kinetis_sdhc.c:
##########
@@ -1913,7 +1913,7 @@ static int kinetis_sendcmd(FAR struct sdio_dev_s *dev,
uint32_t cmd,
****************************************************************************/
#ifdef CONFIG_SDIO_BLOCKSETUP
-static void kinetis_blocksetup(FAR struct sdio_dev_s *dev,
+static void kinetis_blocksetup(struct sdio_dev_s *dev,
unsigned int blocksize,
unsigned int nblocks)
Review Comment:
```suggestion
static void kinetis_blocksetup(struct sdio_dev_s *dev,
unsigned int blocksize,
unsigned int nblocks)
```
##########
arch/arm/src/imxrt/imxrt_adc.c:
##########
@@ -553,12 +553,12 @@ static int adc_interrupt(int irq, void *context, FAR void
*arg)
*
****************************************************************************/
-FAR struct adc_dev_s *imxrt_adcinitialize(int intf,
- FAR const uint8_t *chanlist,
+struct adc_dev_s *imxrt_adcinitialize(int intf,
+ const uint8_t *chanlist,
int nchannels)
Review Comment:
```suggestion
const uint8_t *chanlist,
int nchannels)
```
##########
arch/arm/src/imxrt/imxrt_lpspi.c:
##########
@@ -131,52 +131,52 @@ enum imxrt_delay_e
/* Helpers */
static inline uint32_t
-imxrt_lpspi_getreg32(FAR struct imxrt_lpspidev_s *priv,
+imxrt_lpspi_getreg32(struct imxrt_lpspidev_s *priv,
uint8_t offset);
Review Comment:
```suggestion
imxrt_lpspi_getreg32(struct imxrt_lpspidev_s *priv,
uint8_t offset);
```
##########
arch/arm/src/imxrt/imxrt_flexpwm.c:
##########
@@ -87,28 +87,28 @@ struct imxrt_flexpwm_module_s
struct imxrt_flexpwm_s
{
const struct pwm_ops_s *ops; /* PWM operations */
- FAR struct imxrt_flexpwm_module_s *modules;
+ struct imxrt_flexpwm_module_s *modules;
uint8_t modules_num; /* Number of modules */
uint32_t frequency; /* PWM frequency */
uint32_t base; /* Base address of peripheral register */
};
/* PWM driver methods */
-static int pwm_setup(FAR struct pwm_lowerhalf_s *dev);
-static int pwm_shutdown(FAR struct pwm_lowerhalf_s *dev);
-static int pwm_start(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info);
-static int pwm_stop(FAR struct pwm_lowerhalf_s *dev);
-static int pwm_ioctl(FAR struct pwm_lowerhalf_s *dev,
+static int pwm_setup(struct pwm_lowerhalf_s *dev);
+static int pwm_shutdown(struct pwm_lowerhalf_s *dev);
+static int pwm_start(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info);
+static int pwm_stop(struct pwm_lowerhalf_s *dev);
+static int pwm_ioctl(struct pwm_lowerhalf_s *dev,
int cmd, unsigned long arg);
/* Helper functions */
-static int pwm_set_output(FAR struct pwm_lowerhalf_s *dev, uint8_t channel,
+static int pwm_set_output(struct pwm_lowerhalf_s *dev, uint8_t channel,
ub16_t duty);
-static int pwm_change_freq(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info, uint8_t channel);
+static int pwm_change_freq(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info, uint8_t channel);
Review Comment:
```suggestion
static int pwm_change_freq(struct pwm_lowerhalf_s *dev,
const struct pwm_info_s *info,
uint8_t channel);
```
##########
arch/arm/src/imxrt/imxrt_lcd.c:
##########
@@ -324,8 +324,8 @@ static int imxrt_getcmap(FAR struct fb_vtable_s *vtable,
****************************************************************************/
#ifdef CONFIG_FB_CMAP
-static int imxrt_putcmap(FAR struct fb_vtable_s *vtable,
- FAR const struct fb_cmap_s *cmap)
+static int imxrt_putcmap(struct fb_vtable_s *vtable,
+ const struct fb_cmap_s *cmap)
Review Comment:
```suggestion
static int imxrt_putcmap(struct fb_vtable_s *vtable,
const struct fb_cmap_s *cmap)
```
##########
arch/arm/src/imxrt/imxrt_wdog.c:
##########
@@ -263,10 +263,10 @@ static int imxrt_wdog_keepalive(FAR struct
watchdog_lowerhalf_s *lower)
*
****************************************************************************/
-static int imxrt_wdog_getstatus(FAR struct watchdog_lowerhalf_s *lower,
- FAR struct watchdog_status_s *status)
+static int imxrt_wdog_getstatus(struct watchdog_lowerhalf_s *lower,
+ struct watchdog_status_s *status)
Review Comment:
```suggestion
static int imxrt_wdog_getstatus(struct watchdog_lowerhalf_s *lower,
struct watchdog_status_s *status)
```
##########
arch/arm/src/kinetis/kinetis_sdhc.c:
##########
@@ -2593,7 +2593,7 @@ static sdio_eventset_t kinetis_eventwait(FAR struct
sdio_dev_s *dev)
*
****************************************************************************/
-static void kinetis_callbackenable(FAR struct sdio_dev_s *dev,
+static void kinetis_callbackenable(struct sdio_dev_s *dev,
sdio_eventset_t eventset)
Review Comment:
```suggestion
static void kinetis_callbackenable(struct sdio_dev_s *dev,
sdio_eventset_t eventset)
```
##########
arch/arm/src/imxrt/imxrt_lpi2c.c:
##########
@@ -953,7 +953,7 @@ static void imxrt_lpi2c_tracenew(FAR struct
imxrt_lpi2c_priv_s *priv,
}
}
-static void imxrt_lpi2c_traceevent(FAR struct imxrt_lpi2c_priv_s *priv,
+static void imxrt_lpi2c_traceevent(struct imxrt_lpi2c_priv_s *priv,
enum imxrt_trace_e event, uint32_t parm)
Review Comment:
```suggestion
static void imxrt_lpi2c_traceevent(struct imxrt_lpi2c_priv_s *priv,
enum imxrt_trace_e event, uint32_t parm)
```
##########
arch/arm/src/imxrt/imxrt_usbdev.c:
##########
@@ -2543,11 +2543,11 @@ static int imxrt_epstall(FAR struct usbdev_ep_s *ep,
bool resume)
*
****************************************************************************/
-static FAR struct usbdev_ep_s *imxrt_allocep(FAR struct usbdev_s *dev,
+static struct usbdev_ep_s *imxrt_allocep(struct usbdev_s *dev,
uint8_t eplog,
bool in, uint8_t eptype)
Review Comment:
```suggestion
static struct usbdev_ep_s *imxrt_allocep(struct usbdev_s *dev,
uint8_t eplog,
bool in, uint8_t eptype)
```
##########
arch/arm/src/kinetis/kinetis_sdhc.c:
##########
@@ -2723,8 +2723,8 @@ static int kinetis_dmarecvsetup(FAR struct sdio_dev_s
*dev,
****************************************************************************/
#ifdef CONFIG_KINETIS_SDHC_DMA
-static int kinetis_dmasendsetup(FAR struct sdio_dev_s *dev,
- FAR const uint8_t *buffer, size_t buflen)
+static int kinetis_dmasendsetup(struct sdio_dev_s *dev,
+ const uint8_t *buffer, size_t buflen)
Review Comment:
```suggestion
static int kinetis_dmasendsetup(struct sdio_dev_s *dev,
const uint8_t *buffer, size_t buflen)
```
##########
arch/arm/src/kinetis/kinetis_rtc_lowerhalf.c:
##########
@@ -153,14 +153,14 @@ static struct kinetis_lowerhalf_s g_rtc_lowerhalf =
#ifdef CONFIG_RTC_ALARM
static void kinetis_alarm_callback(void)
{
- FAR struct kinetis_cbinfo_s *cbinfo = &g_rtc_lowerhalf.cbinfo;
+ struct kinetis_cbinfo_s *cbinfo = &g_rtc_lowerhalf.cbinfo;
/* Sample and clear the callback information to minimize the window in
* time in which race conditions can occur.
*/
rtc_alarm_callback_t cb = (rtc_alarm_callback_t)cbinfo->cb;
- FAR void *arg = (FAR void *)cbinfo->priv;
+ void *arg = (void *)cbinfo->priv;
Review Comment:
```suggestion
void *arg = (void *)cbinfo->priv;
```
##########
arch/arm/src/kinetis/kinetis_sdhc.c:
##########
@@ -2427,7 +2427,7 @@ static int kinetis_recvnotimpl(FAR struct sdio_dev_s
*dev, uint32_t cmd,
*
****************************************************************************/
-static void kinetis_waitenable(FAR struct sdio_dev_s *dev,
+static void kinetis_waitenable(struct sdio_dev_s *dev,
sdio_eventset_t eventset, uint32_t timeout)
Review Comment:
```suggestion
static void kinetis_waitenable(struct sdio_dev_s *dev,
sdio_eventset_t eventset, uint32_t timeout)
```
##########
arch/arm/src/kinetis/kinetis_usbhshost.c:
##########
@@ -3923,8 +3923,8 @@ static int kinetis_rh_enumerate(FAR struct
usbhost_connection_s *conn,
return OK;
}
-static int kinetis_enumerate(FAR struct usbhost_connection_s *conn,
- FAR struct usbhost_hubport_s *hport)
+static int kinetis_enumerate(struct usbhost_connection_s *conn,
+ struct usbhost_hubport_s *hport)
Review Comment:
```suggestion
static int kinetis_enumerate(struct usbhost_connection_s *conn,
struct usbhost_hubport_s *hport)
```
##########
arch/arm/src/kinetis/kinetis_usbhshost.c:
##########
@@ -4174,8 +4174,8 @@ static int kinetis_epfree(FAR struct usbhost_driver_s
*drvr, usbhost_ep_t ep)
*
****************************************************************************/
-static int kinetis_alloc(FAR struct usbhost_driver_s *drvr,
- FAR uint8_t **buffer, FAR size_t *maxlen)
+static int kinetis_alloc(struct usbhost_driver_s *drvr,
+ uint8_t **buffer, size_t *maxlen)
Review Comment:
```suggestion
static int kinetis_alloc(struct usbhost_driver_s *drvr,
uint8_t **buffer, size_t *maxlen)
```
##########
arch/arm/src/kinetis/kinetis_usbhshost.c:
##########
@@ -4185,7 +4185,7 @@ static int kinetis_alloc(FAR struct usbhost_driver_s
*drvr,
* multiple of the cache line size in length.
*/
- *buffer = (FAR uint8_t *)kmm_memalign(ARMV7M_DCACHE_LINESIZE,
+ *buffer = (uint8_t *)kmm_memalign(ARMV7M_DCACHE_LINESIZE,
KINETIS_EHCI_BUFSIZE);
Review Comment:
```suggestion
*buffer = (uint8_t *)kmm_memalign(ARMV7M_DCACHE_LINESIZE,
KINETIS_EHCI_BUFSIZE);
```
##########
arch/arm/src/kl/kl_gpioirq.c:
##########
@@ -100,7 +100,7 @@ static struct g_portisrs_s g_portdisrs[32];
****************************************************************************/
#ifdef HAVE_PORTINTS
-static int kl_portinterrupt(int irq, FAR void *context,
+static int kl_portinterrupt(int irq, void *context,
uintptr_t addr, xcpt_t *isrtab)
Review Comment:
```suggestion
static int kl_portinterrupt(int irq, void *context,
uintptr_t addr, xcpt_t *isrtab)
```
##########
arch/arm/src/kinetis/kinetis_usbhshost.c:
##########
@@ -4301,8 +4301,8 @@ static int kinetis_ioalloc(FAR struct usbhost_driver_s
*drvr,
*
****************************************************************************/
-static int kinetis_iofree(FAR struct usbhost_driver_s *drvr,
- FAR uint8_t *buffer)
+static int kinetis_iofree(struct usbhost_driver_s *drvr,
+ uint8_t *buffer)
Review Comment:
```suggestion
static int kinetis_iofree(struct usbhost_driver_s *drvr,
uint8_t *buffer)
```
##########
arch/arm/src/kinetis/kinetis_usbhshost.c:
##########
@@ -4878,8 +4878,8 @@ static int kinetis_cancel(FAR struct usbhost_driver_s
*drvr, usbhost_ep_t ep)
****************************************************************************/
#ifdef CONFIG_USBHOST_HUB
-static int kinetis_connect(FAR struct usbhost_driver_s *drvr,
- FAR struct usbhost_hubport_s *hport,
+static int kinetis_connect(struct usbhost_driver_s *drvr,
+ struct usbhost_hubport_s *hport,
bool connected)
Review Comment:
```suggestion
static int kinetis_connect(struct usbhost_driver_s *drvr,
struct usbhost_hubport_s *hport,
bool connected)
```
##########
arch/arm/src/kinetis/kinetis_usbhshost.c:
##########
@@ -3604,8 +3604,8 @@ static int kinetis_ehci_interrupt(int irq, FAR void
*context, FAR void *arg)
*
****************************************************************************/
-static int kinetis_wait(FAR struct usbhost_connection_s *conn,
- FAR struct usbhost_hubport_s **hport)
+static int kinetis_wait(struct usbhost_connection_s *conn,
+ struct usbhost_hubport_s **hport)
Review Comment:
```suggestion
static int kinetis_wait(struct usbhost_connection_s *conn,
struct usbhost_hubport_s **hport)
```
##########
arch/arm/src/lc823450/lc823450_mmcl.c:
##########
@@ -50,26 +50,26 @@
struct mmcl_dev_s
{
#ifdef CONFIG_FS_EVFAT
- uint32_t channel; /* 0: eMMC, 1: SD */
+ uint32_t channel; /* 0: eMMC, 1: SD */
#endif
- FAR struct mtd_dev_s *mtd; /* Contained MTD interface */
- struct mtd_geometry_s geo; /* Device geometry */
+ struct mtd_dev_s *mtd; /* Contained MTD interface */
+ struct mtd_geometry_s geo; /* Device geometry */
Review Comment:
```suggestion
struct mtd_dev_s *mtd; /* Contained MTD interface */
struct mtd_geometry_s geo; /* Device geometry */
```
##########
arch/arm/src/kinetis/kinetis_usbhshost.c:
##########
@@ -4579,9 +4579,9 @@ static ssize_t kinetis_transfer(FAR struct
usbhost_driver_s *drvr,
****************************************************************************/
#ifdef CONFIG_USBHOST_ASYNCH
-static int kinetis_asynch(FAR struct usbhost_driver_s *drvr, usbhost_ep_t ep,
- FAR uint8_t *buffer, size_t buflen,
- usbhost_asynch_t callback, FAR void *arg)
+static int kinetis_asynch(struct usbhost_driver_s *drvr, usbhost_ep_t ep,
+ uint8_t *buffer, size_t buflen,
+ usbhost_asynch_t callback, void *arg)
Review Comment:
```suggestion
static int kinetis_asynch(struct usbhost_driver_s *drvr, usbhost_ep_t ep,
uint8_t *buffer, size_t buflen,
usbhost_asynch_t callback, void *arg)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c:
##########
@@ -127,18 +127,18 @@ struct lpc17_40_i2cdev_s
static int lpc17_40_i2c_start(struct lpc17_40_i2cdev_s *priv);
static void lpc17_40_i2c_stop(struct lpc17_40_i2cdev_s *priv);
-static int lpc17_40_i2c_interrupt(int irq, FAR void *context, void *arg);
+static int lpc17_40_i2c_interrupt(int irq, void *context, void *arg);
static void lpc17_40_i2c_timeout(wdparm_t arg);
static void lpc17_40_i2c_setfrequency(struct lpc17_40_i2cdev_s *priv,
uint32_t frequency);
static void lpc17_40_stopnext(struct lpc17_40_i2cdev_s *priv);
/* I2C device operations */
-static int lpc17_40_i2c_transfer(FAR struct i2c_master_s *dev,
- FAR struct i2c_msg_s *msgs, int count);
+static int lpc17_40_i2c_transfer(struct i2c_master_s *dev,
+ struct i2c_msg_s *msgs, int count);
Review Comment:
```suggestion
static int lpc17_40_i2c_transfer(struct i2c_master_s *dev,
struct i2c_msg_s *msgs,
int count);
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c:
##########
@@ -292,8 +292,8 @@ static void lpc17_40_i2c_timeout(wdparm_t arg)
*
****************************************************************************/
-static int lpc17_40_i2c_transfer(FAR struct i2c_master_s *dev,
- FAR struct i2c_msg_s *msgs, int count)
+static int lpc17_40_i2c_transfer(struct i2c_master_s *dev,
+ struct i2c_msg_s *msgs, int count)
Review Comment:
```suggestion
static int lpc17_40_i2c_transfer(struct i2c_master_s *dev,
struct i2c_msg_s *msgs, int count)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_lcd.c:
##########
@@ -185,8 +185,8 @@ struct fb_vtable_s g_fbobject =
* Name: lpc17_40_getvideoinfo
****************************************************************************/
-static int lpc17_40_getvideoinfo(FAR struct fb_vtable_s *vtable,
- FAR struct fb_videoinfo_s *vinfo)
+static int lpc17_40_getvideoinfo(struct fb_vtable_s *vtable,
+ struct fb_videoinfo_s *vinfo)
Review Comment:
```suggestion
static int lpc17_40_getvideoinfo(struct fb_vtable_s *vtable,
struct fb_videoinfo_s *vinfo)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_lcd.c:
##########
@@ -222,8 +222,8 @@ static int lpc17_40_getplaneinfo(FAR struct fb_vtable_s
*vtable, int planeno,
****************************************************************************/
#ifdef CONFIG_FB_CMAP
-static int lpc17_40_getcmap(FAR struct fb_vtable_s *vtable,
- FAR struct fb_cmap_s *cmap)
+static int lpc17_40_getcmap(struct fb_vtable_s *vtable,
+ struct fb_cmap_s *cmap)
Review Comment:
```suggestion
static int lpc17_40_getcmap(struct fb_vtable_s *vtable,
struct fb_cmap_s *cmap)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_usbdev.c:
##########
@@ -2656,11 +2656,11 @@ static void lpc17_40_dmadisable(uint8_t epphy)
*
****************************************************************************/
-static int lpc17_40_epconfigure(FAR struct usbdev_ep_s *ep,
- FAR const struct usb_epdesc_s *desc,
+static int lpc17_40_epconfigure(struct usbdev_ep_s *ep,
+ const struct usb_epdesc_s *desc,
bool last)
Review Comment:
```suggestion
static int lpc17_40_epconfigure(struct usbdev_ep_s *ep,
const struct usb_epdesc_s *desc,
bool last)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_usbdev.c:
##########
@@ -837,8 +837,8 @@ struct lpc17_40_req_s *lpc17_40_rqdequeue(FAR struct
lpc17_40_ep_s *privep)
*
****************************************************************************/
-static void lpc17_40_rqenqueue(FAR struct lpc17_40_ep_s *privep,
- FAR struct lpc17_40_req_s *req)
+static void lpc17_40_rqenqueue(struct lpc17_40_ep_s *privep,
+ struct lpc17_40_req_s *req)
Review Comment:
```suggestion
static void lpc17_40_rqenqueue(struct lpc17_40_ep_s *privep,
struct lpc17_40_req_s *req)
```
##########
arch/arm/src/kinetis/kinetis_usbhshost.c:
##########
@@ -4262,8 +4262,8 @@ static int kinetis_free(FAR struct usbhost_driver_s *drvr,
*
****************************************************************************/
-static int kinetis_ioalloc(FAR struct usbhost_driver_s *drvr,
- FAR uint8_t **buffer, size_t buflen)
+static int kinetis_ioalloc(struct usbhost_driver_s *drvr,
+ uint8_t **buffer, size_t buflen)
Review Comment:
```suggestion
static int kinetis_ioalloc(struct usbhost_driver_s *drvr,
uint8_t **buffer, size_t buflen)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_timer.c:
##########
@@ -103,26 +103,26 @@ static void timer_putreg(struct lpc17_40_timer_s *priv,
#ifdef CONFIG_DEBUG_PWM_INFO
static void timer_dumpregs(struct lpc17_40_timer_s *priv,
- FAR const char *msg);
+ const char *msg);
#else
# define timer_dumpregs(priv,msg)
#endif
/* Timer management */
-static int timer_timer(FAR struct lpc17_40_timer_s *priv,
- FAR const struct pwm_info_s *info);
+static int timer_timer(struct lpc17_40_timer_s *priv,
+ const struct pwm_info_s *info);
/* PWM driver methods */
-static int timer_setup(FAR struct pwm_lowerhalf_s *dev);
-static int timer_shutdown(FAR struct pwm_lowerhalf_s *dev);
+static int timer_setup(struct pwm_lowerhalf_s *dev);
+static int timer_shutdown(struct pwm_lowerhalf_s *dev);
-static int timer_start(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info);
+static int timer_start(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info);
-static int timer_stop(FAR struct pwm_lowerhalf_s *dev);
-static int timer_ioctl(FAR struct pwm_lowerhalf_s *dev,
+static int timer_stop(struct pwm_lowerhalf_s *dev);
+static int timer_ioctl(struct pwm_lowerhalf_s *dev,
int cmd, unsigned long arg);
Review Comment:
```suggestion
static int timer_ioctl(struct pwm_lowerhalf_s *dev,
int cmd, unsigned long arg);
```
##########
arch/arm/src/lpc214x/lpc214x_usbdev.c:
##########
@@ -2779,12 +2779,12 @@ static void lpc214x_epfreereq(FAR struct usbdev_ep_s
*ep,
****************************************************************************/
#ifdef CONFIG_LPC214X_USBDEV_DMA
-static FAR void *lpc214x_epallocbuffer(FAR struct usbdev_ep_s *ep,
+static void *lpc214x_epallocbuffer(struct usbdev_ep_s *ep,
uint16_t nbytes)
Review Comment:
```suggestion
static void *lpc214x_epallocbuffer(struct usbdev_ep_s *ep,
uint16_t nbytes)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_usbdev.c:
##########
@@ -3063,11 +3063,11 @@ static int lpc17_40_epstall(FAR struct usbdev_ep_s *ep,
bool resume)
*
****************************************************************************/
-static FAR struct usbdev_ep_s *lpc17_40_allocep(FAR struct usbdev_s *dev,
+static struct usbdev_ep_s *lpc17_40_allocep(struct usbdev_s *dev,
uint8_t eplog,
bool in, uint8_t eptype)
Review Comment:
```suggestion
static struct usbdev_ep_s *lpc17_40_allocep(struct usbdev_s *dev,
uint8_t eplog,
bool in, uint8_t eptype)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_sdcard.c:
##########
@@ -2445,7 +2445,7 @@ static void lpc17_40_callbackenable(FAR struct sdio_dev_s
*dev,
*
****************************************************************************/
-static int lpc17_40_registercallback(FAR struct sdio_dev_s *dev,
+static int lpc17_40_registercallback(struct sdio_dev_s *dev,
worker_t callback, void *arg)
Review Comment:
```suggestion
static int lpc17_40_registercallback(struct sdio_dev_s *dev,
worker_t callback, void *arg)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_timer.c:
##########
@@ -103,26 +103,26 @@ static void timer_putreg(struct lpc17_40_timer_s *priv,
#ifdef CONFIG_DEBUG_PWM_INFO
static void timer_dumpregs(struct lpc17_40_timer_s *priv,
- FAR const char *msg);
+ const char *msg);
#else
# define timer_dumpregs(priv,msg)
#endif
/* Timer management */
-static int timer_timer(FAR struct lpc17_40_timer_s *priv,
- FAR const struct pwm_info_s *info);
+static int timer_timer(struct lpc17_40_timer_s *priv,
+ const struct pwm_info_s *info);
/* PWM driver methods */
-static int timer_setup(FAR struct pwm_lowerhalf_s *dev);
-static int timer_shutdown(FAR struct pwm_lowerhalf_s *dev);
+static int timer_setup(struct pwm_lowerhalf_s *dev);
+static int timer_shutdown(struct pwm_lowerhalf_s *dev);
-static int timer_start(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info);
+static int timer_start(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info);
Review Comment:
```suggestion
static int timer_start(struct pwm_lowerhalf_s *dev,
const struct pwm_info_s *info);
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_lcd.c:
##########
@@ -401,8 +401,8 @@ static int lpc17_40_getcursor(FAR struct fb_vtable_s
*vtable,
****************************************************************************/
#ifdef CONFIG_FB_HWCURSOR
-static int lpc17_40_setcursor(FAR struct fb_vtable_s *vtable,
- FAR struct fb_setcursor_s *settings)
+static int lpc17_40_setcursor(struct fb_vtable_s *vtable,
+ struct fb_setcursor_s *settings)
Review Comment:
```suggestion
static int lpc17_40_setcursor(struct fb_vtable_s *vtable,
struct fb_setcursor_s *settings)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_lcd.c:
##########
@@ -368,8 +368,8 @@ static int lpc17_40_putcmap(FAR struct fb_vtable_s *vtable,
****************************************************************************/
#ifdef CONFIG_FB_HWCURSOR
-static int lpc17_40_getcursor(FAR struct fb_vtable_s *vtable,
- FAR struct fb_cursorattrib_s *attrib)
+static int lpc17_40_getcursor(struct fb_vtable_s *vtable,
+ struct fb_cursorattrib_s *attrib)
Review Comment:
```suggestion
static int lpc17_40_getcursor(struct fb_vtable_s *vtable,
struct fb_cursorattrib_s *attrib)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_lcd.c:
##########
@@ -296,8 +296,8 @@ static int lpc17_40_getcmap(FAR struct fb_vtable_s *vtable,
****************************************************************************/
#ifdef CONFIG_FB_CMAP
-static int lpc17_40_putcmap(FAR struct fb_vtable_s *vtable,
- FAR const struct fb_cmap_s *cmap)
+static int lpc17_40_putcmap(struct fb_vtable_s *vtable,
+ const struct fb_cmap_s *cmap)
Review Comment:
```suggestion
static int lpc17_40_putcmap(struct fb_vtable_s *vtable,
const struct fb_cmap_s *cmap)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_usbdev.c:
##########
@@ -2815,12 +2815,12 @@ static void lpc17_40_epfreereq(FAR struct usbdev_ep_s
*ep,
****************************************************************************/
#ifdef CONFIG_USBDEV_DMA
-static FAR void *lpc17_40_epallocbuffer(FAR struct usbdev_ep_s *ep,
+static void *lpc17_40_epallocbuffer(struct usbdev_ep_s *ep,
uint16_t nbytes)
Review Comment:
```suggestion
static void *lpc17_40_epallocbuffer(struct usbdev_ep_s *ep,
uint16_t nbytes)
```
##########
arch/arm/src/lpc2378/lpc23xx_i2c.c:
##########
@@ -394,8 +394,8 @@ static int lpc2378_i2c_interrupt(int irq, FAR void
*context, FAR void *arg)
*
****************************************************************************/
-static int lpc2378_i2c_transfer(FAR struct i2c_master_s *dev,
- FAR struct i2c_msg_s *msgs, int count)
+static int lpc2378_i2c_transfer(struct i2c_master_s *dev,
+ struct i2c_msg_s *msgs, int count)
Review Comment:
```suggestion
static int lpc2378_i2c_transfer(struct i2c_master_s *dev,
struct i2c_msg_s *msgs, int count)
```
##########
arch/arm/src/lpc31xx/lpc31_usbdev.c:
##########
@@ -352,9 +352,9 @@ static inline void lpc31_chgbits(uint32_t mask, uint32_t
val,
/* Request queue operations *************************************************/
static FAR
Review Comment:
```suggestion
static
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_sdcard.c:
##########
@@ -2411,7 +2411,7 @@ static sdio_eventset_t lpc17_40_eventwait(FAR struct
sdio_dev_s *dev)
*
****************************************************************************/
-static void lpc17_40_callbackenable(FAR struct sdio_dev_s *dev,
+static void lpc17_40_callbackenable(struct sdio_dev_s *dev,
sdio_eventset_t eventset)
Review Comment:
```suggestion
static void lpc17_40_callbackenable(struct sdio_dev_s *dev,
sdio_eventset_t eventset)
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_mcpwm.c:
##########
@@ -103,26 +103,26 @@ static void mcpwm_putreg(struct lpc17_40_mcpwmtimer_s
*priv,
#ifdef CONFIG_DEBUG_PWM_INFO
static void mcpwm_dumpregs(struct lpc17_40_mcpwmtimer_s *priv,
- FAR const char *msg);
+ const char *msg);
#else
# define mcpwm_dumpregs(priv,msg)
#endif
/* Timer management */
-static int mcpwm_timer(FAR struct lpc17_40_mcpwmtimer_s *priv,
- FAR const struct pwm_info_s *info);
+static int mcpwm_timer(struct lpc17_40_mcpwmtimer_s *priv,
+ const struct pwm_info_s *info);
/* PWM driver methods */
-static int mcpwm_setup(FAR struct pwm_lowerhalf_s *dev);
-static int mcpwm_shutdown(FAR struct pwm_lowerhalf_s *dev);
+static int mcpwm_setup(struct pwm_lowerhalf_s *dev);
+static int mcpwm_shutdown(struct pwm_lowerhalf_s *dev);
-static int mcpwm_start(FAR struct pwm_lowerhalf_s *dev,
- FAR const struct pwm_info_s *info);
+static int mcpwm_start(struct pwm_lowerhalf_s *dev,
+ const struct pwm_info_s *info);
-static int mcpwm_stop(FAR struct pwm_lowerhalf_s *dev);
-static int mcpwm_ioctl(FAR struct pwm_lowerhalf_s *dev,
+static int mcpwm_stop(struct pwm_lowerhalf_s *dev);
+static int mcpwm_ioctl(struct pwm_lowerhalf_s *dev,
int cmd, unsigned long arg);
Review Comment:
```suggestion
static int mcpwm_ioctl(struct pwm_lowerhalf_s *dev,
int cmd, unsigned long arg);
```
##########
arch/arm/src/lpc31xx/lpc31_usbdev.c:
##########
@@ -402,36 +402,36 @@ static bool lpc31_epcomplete(struct lpc31_usbdev_s
*priv,
uint8_t epphy);
static int lpc31_usbinterrupt(int irq,
- FAR void *context, FAR void *arg);
+ void *context, void *arg);
/* Endpoint operations ******************************************************/
/* USB device controller operations *****************************************/
-static int lpc31_epconfigure(FAR struct usbdev_ep_s *ep,
+static int lpc31_epconfigure(struct usbdev_ep_s *ep,
const struct usb_epdesc_s *desc,
bool last);
-static int lpc31_epdisable(FAR struct usbdev_ep_s *ep);
+static int lpc31_epdisable(struct usbdev_ep_s *ep);
static FAR
Review Comment:
```suggestion
static
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_sdcard.c:
##########
@@ -2563,8 +2563,8 @@ static int lpc17_40_dmarecvsetup(FAR struct sdio_dev_s
*dev,
****************************************************************************/
#ifdef CONFIG_LPC17_40_SDCARD_DMA
-static int lpc17_40_dmasendsetup(FAR struct sdio_dev_s *dev,
- FAR const uint8_t *buffer, size_t buflen)
+static int lpc17_40_dmasendsetup(struct sdio_dev_s *dev,
+ const uint8_t *buffer, size_t buflen)
Review Comment:
```suggestion
static int lpc17_40_dmasendsetup(struct sdio_dev_s *dev,
const uint8_t *buffer, size_t buflen)
```
##########
arch/arm/src/lpc31xx/lpc31_usbdev.c:
##########
@@ -624,9 +624,9 @@ static inline void lpc31_chgbits(uint32_t mask, uint32_t
val, uint32_t addr)
****************************************************************************/
static FAR
Review Comment:
```suggestion
static
```
##########
arch/arm/src/lpc43xx/lpc43_allocateheap.c:
##########
@@ -545,7 +545,7 @@ void arm_addregion(void)
#ifdef MM_USE_AHBSRAM_BANK0
/* Add the SRAM to the user heap */
- mem_addregion((FAR void *)LPC43_AHBSRAM_BANK0_BASE,
+ mem_addregion((void *)LPC43_AHBSRAM_BANK0_BASE,
LPC43_AHBSRAM_BANK0_SIZE);
Review Comment:
```suggestion
mem_addregion((void *)LPC43_AHBSRAM_BANK0_BASE,
LPC43_AHBSRAM_BANK0_SIZE);
```
##########
arch/arm/src/lpc43xx/lpc43_allocateheap.c:
##########
@@ -559,7 +559,7 @@ void arm_addregion(void)
#ifdef MM_USE_AHBSRAM_BANK1
/* Add the SRAM to the user heap */
- mem_addregion((FAR void *)LPC43_AHBSRAM_BANK1_BASE,
+ mem_addregion((void *)LPC43_AHBSRAM_BANK1_BASE,
LPC43_AHBSRAM_BANK1_SIZE);
Review Comment:
```suggestion
mem_addregion((void *)LPC43_AHBSRAM_BANK1_BASE,
LPC43_AHBSRAM_BANK1_SIZE);
```
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_timer.c:
##########
@@ -103,26 +103,26 @@ static void timer_putreg(struct lpc17_40_timer_s *priv,
#ifdef CONFIG_DEBUG_PWM_INFO
static void timer_dumpregs(struct lpc17_40_timer_s *priv,
- FAR const char *msg);
+ const char *msg);
#else
# define timer_dumpregs(priv,msg)
#endif
/* Timer management */
-static int timer_timer(FAR struct lpc17_40_timer_s *priv,
- FAR const struct pwm_info_s *info);
+static int timer_timer(struct lpc17_40_timer_s *priv,
+ const struct pwm_info_s *info);
Review Comment:
```suggestion
static int timer_timer(struct lpc17_40_timer_s *priv,
const struct pwm_info_s *info);
```
##########
arch/arm/src/lpc43xx/lpc43_allocateheap.c:
##########
@@ -531,7 +531,7 @@ void arm_addregion(void)
#ifdef MM_USE_LOCSRAM_BANK1
/* Add the SRAM to the user heap */
- mem_addregion((FAR void *)LPC43_LOCSRAM_BANK1_BASE,
+ mem_addregion((void *)LPC43_LOCSRAM_BANK1_BASE,
LPC43_LOCSRAM_BANK1_SIZE);
Review Comment:
```suggestion
mem_addregion((void *)LPC43_LOCSRAM_BANK1_BASE,
LPC43_LOCSRAM_BANK1_SIZE);
```
##########
arch/arm/src/lpc54xx/lpc54_allocateheap.c:
##########
@@ -277,7 +277,7 @@ void arm_addregion(void)
{
/* Add the SRAM to the user heap */
- heapstart = (FAR void *)(LPC54_SRAMCS1_BASE +
+ heapstart = (void *)(LPC54_SRAMCS1_BASE +
CONFIG_LPC54_EMC_STATIC_CS1_OFFSET);
Review Comment:
```suggestion
heapstart = (void *)(LPC54_SRAMCS1_BASE +
CONFIG_LPC54_EMC_STATIC_CS1_OFFSET);
```
##########
arch/arm/src/lpc43xx/lpc43_timer.c:
##########
@@ -663,10 +663,10 @@ static void lpc43_setcallback(FAR struct
timer_lowerhalf_s *lower,
*
****************************************************************************/
-static int lpc43_ioctl(FAR struct timer_lowerhalf_s *lower, int cmd,
+static int lpc43_ioctl(struct timer_lowerhalf_s *lower, int cmd,
unsigned long arg)
Review Comment:
```suggestion
static int lpc43_ioctl(struct timer_lowerhalf_s *lower, int cmd,
unsigned long arg)
```
##########
arch/arm/src/lpc54xx/lpc54_allocateheap.c:
##########
@@ -250,15 +250,15 @@ void up_allocate_kheap(FAR void **heap_start, size_t
*heap_size)
void arm_addregion(void)
{
int remaining = CONFIG_MM_REGIONS;
- FAR void *heapstart;
+ void *heapstart;
size_t heapsize;
#ifdef HAVE_STATIC_CS0
if (remaining > 0)
{
/* Add the SRAM to the user heap */
- heapstart = (FAR void *)(LPC54_SRAMCS0_BASE +
+ heapstart = (void *)(LPC54_SRAMCS0_BASE +
CONFIG_LPC54_EMC_STATIC_CS0_OFFSET);
Review Comment:
```suggestion
heapstart = (void *)(LPC54_SRAMCS0_BASE +
CONFIG_LPC54_EMC_STATIC_CS0_OFFSET);
```
##########
arch/arm/src/lpc43xx/lpc43_ehci.c:
##########
@@ -3962,15 +3962,15 @@ static int lpc43_epfree(FAR struct usbhost_driver_s
*drvr, usbhost_ep_t ep)
*
****************************************************************************/
-static int lpc43_alloc(FAR struct usbhost_driver_s *drvr,
- FAR uint8_t **buffer, FAR size_t *maxlen)
+static int lpc43_alloc(struct usbhost_driver_s *drvr,
+ uint8_t **buffer, size_t *maxlen)
Review Comment:
```suggestion
static int lpc43_alloc(struct usbhost_driver_s *drvr,
uint8_t **buffer, size_t *maxlen)
```
##########
arch/arm/src/lpc43xx/lpc43_timer.c:
##########
@@ -624,10 +624,10 @@ static int lpc43_settimeout(FAR struct timer_lowerhalf_s
*lower,
*
****************************************************************************/
-static void lpc43_setcallback(FAR struct timer_lowerhalf_s *lower,
- tccb_t callback, FAR void *arg)
+static void lpc43_setcallback(struct timer_lowerhalf_s *lower,
+ tccb_t callback, void *arg)
Review Comment:
```suggestion
static void lpc43_setcallback(struct timer_lowerhalf_s *lower,
tccb_t callback, void *arg)
```
##########
arch/arm/src/lpc43xx/lpc43_usb0dev.c:
##########
@@ -651,8 +651,8 @@ static FAR struct lpc43_req_s *lpc43_rqdequeue(FAR struct
lpc43_ep_s *privep)
*
****************************************************************************/
-static bool lpc43_rqenqueue(FAR struct lpc43_ep_s *privep,
- FAR struct lpc43_req_s *req)
+static bool lpc43_rqenqueue(struct lpc43_ep_s *privep,
+ struct lpc43_req_s *req)
Review Comment:
```suggestion
static bool lpc43_rqenqueue(struct lpc43_ep_s *privep,
struct lpc43_req_s *req)
```
##########
arch/arm/src/lpc54xx/lpc54_allocateheap.c:
##########
@@ -296,7 +296,7 @@ void arm_addregion(void)
{
/* Add the SRAM to the user heap */
- heapstart = (FAR void *)(LPC54_SRAMCS2_BASE +
+ heapstart = (void *)(LPC54_SRAMCS2_BASE +
CONFIG_LPC54_EMC_STATIC_CS2_OFFSET);
Review Comment:
```suggestion
heapstart = (void *)(LPC54_SRAMCS2_BASE +
CONFIG_LPC54_EMC_STATIC_CS2_OFFSET);
```
##########
arch/arm/src/lpc54xx/lpc54_allocateheap.c:
##########
@@ -334,7 +334,7 @@ void arm_addregion(void)
{
/* Add the SDRAM to the user heap */
- heapstart = (FAR void *)(LPC54_DRAMCS0_BASE +
+ heapstart = (void *)(LPC54_DRAMCS0_BASE +
CONFIG_LPC54_EMC_DYNAMIC_CS0_OFFSET);
Review Comment:
```suggestion
heapstart = (void *)(LPC54_DRAMCS0_BASE +
CONFIG_LPC54_EMC_DYNAMIC_CS0_OFFSET);
```
##########
arch/arm/src/lpc43xx/lpc43_usb0dev.c:
##########
@@ -2461,11 +2461,11 @@ static int lpc43_epstall(FAR struct usbdev_ep_s *ep,
bool resume)
*
****************************************************************************/
-static FAR struct usbdev_ep_s *lpc43_allocep(FAR struct usbdev_s *dev,
+static struct usbdev_ep_s *lpc43_allocep(struct usbdev_s *dev,
uint8_t eplog,
bool in, uint8_t eptype)
Review Comment:
```suggestion
static struct usbdev_ep_s *lpc43_allocep(struct usbdev_s *dev,
uint8_t eplog,
bool in, uint8_t eptype)
```
##########
arch/arm/src/lpc54xx/lpc54_allocateheap.c:
##########
@@ -353,7 +353,7 @@ void arm_addregion(void)
{
/* Add the SDRAM to the user heap */
- heapstart = (FAR void *)(LPC54_DRAMCS1_BASE +
+ heapstart = (void *)(LPC54_DRAMCS1_BASE +
CONFIG_LPC54_EMC_DYNAMIC_CS1_OFFSET);
Review Comment:
```suggestion
heapstart = (void *)(LPC54_DRAMCS1_BASE +
CONFIG_LPC54_EMC_DYNAMIC_CS1_OFFSET);
```
##########
arch/arm/src/lpc43xx/lpc43_usb0dev.c:
##########
@@ -2037,11 +2037,11 @@ static int lpc43_usbinterrupt(int irq, FAR void
*context, FAR void *arg)
*
****************************************************************************/
-static int lpc43_epconfigure(FAR struct usbdev_ep_s *ep,
- FAR const struct usb_epdesc_s *desc,
+static int lpc43_epconfigure(struct usbdev_ep_s *ep,
+ const struct usb_epdesc_s *desc,
bool last)
Review Comment:
```suggestion
static int lpc43_epconfigure(struct usbdev_ep_s *ep,
const struct usb_epdesc_s *desc,
bool last)
```
##########
arch/arm/src/lpc54xx/lpc54_allocateheap.c:
##########
@@ -391,7 +391,7 @@ void arm_addregion(void)
{
/* Add the SDRAM to the user heap */
- heapstart = (FAR void *)(LPC54_DRAMCS3_BASE +
+ heapstart = (void *)(LPC54_DRAMCS3_BASE +
CONFIG_LPC54_EMC_DYNAMIC_CS3_OFFSET);
Review Comment:
```suggestion
heapstart = (void *)(LPC54_DRAMCS3_BASE +
CONFIG_LPC54_EMC_DYNAMIC_CS3_OFFSET);
```
##########
arch/arm/src/lpc54xx/lpc54_allocateheap.c:
##########
@@ -315,7 +315,7 @@ void arm_addregion(void)
{
/* Add the SRAM to the user heap */
- heapstart = (FAR void *)(LPC54_SRAMCS3_BASE +
+ heapstart = (void *)(LPC54_SRAMCS3_BASE +
CONFIG_LPC54_EMC_STATIC_CS3_OFFSET);
Review Comment:
```suggestion
heapstart = (void *)(LPC54_SRAMCS3_BASE +
CONFIG_LPC54_EMC_STATIC_CS3_OFFSET);
```
##########
arch/arm/src/lpc54xx/lpc54_allocateheap.c:
##########
@@ -372,7 +372,7 @@ void arm_addregion(void)
{
/* Add the SDRAM to the user heap */
- heapstart = (FAR void *)(LPC54_DRAMCS2_BASE +
+ heapstart = (void *)(LPC54_DRAMCS2_BASE +
CONFIG_LPC54_EMC_DYNAMIC_CS2_OFFSET);
Review Comment:
```suggestion
heapstart = (void *)(LPC54_DRAMCS2_BASE +
CONFIG_LPC54_EMC_DYNAMIC_CS2_OFFSET);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
