pussuw commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-nuttx/pull/5962#discussion_r841124753
##########
File path: arch/risc-v/src/common/riscv_percpu.h
##########
@@ -39,9 +39,9 @@
****************************************************************************/
#ifdef __ASSEMBLY__
-#define SCRATCH_HARTID_OFFSET (0 * INT_REG_SIZE)
+#define RISCV_HARTID_OFFSET (0 * INT_REG_SIZE)
#else
-#define SCRATCH_HARTID_OFFSET offsetof(riscv_percpu_s, hartid)
+#define RISCV_HARTID_OFFSET offsetof(riscv_percpu_s, hartid)
Review comment:
IMO the prefix should pre PERCPU_ like the file name. The original name
before I published this was riscv_scratch.c/h but I changed it and forgot to
fix the names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
