xiaoxiang781216 commented on a change in pull request #1114:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1114#discussion_r840441662
##########
File path: system/trace/trace.c
##########
@@ -142,10 +142,22 @@ static int trace_cmd_start(int index, int argc, FAR char
**argv,
static int trace_cmd_dump(int index, int argc, FAR char **argv,
int notectlfd)
{
+ trace_dump_t type = TRACE_TYPE_LTTNG_KERNEL;
FAR FILE *out = stdout;
- int ret;
bool changed = false;
bool cont = false;
+ int ret;
+
+ /* Usage: trace dump [-t] <dumptype> */
Review comment:
update the help message
##########
File path: system/trace/trace.h
##########
@@ -37,6 +37,20 @@ extern "C"
#define EXTERN extern
#endif
+/****************************************************************************
+ * Public Types
+ ****************************************************************************/
+
+typedef enum
+{
+ TRACE_TYPE_LTTNG_KERNEL = 0, /* Common Trace Format : Linux Kernel Trace */
Review comment:
LTTNG_KERNEL->LINUX？
##########
File path: system/trace/trace.h
##########
@@ -37,6 +37,20 @@ extern "C"
#define EXTERN extern
#endif
+/****************************************************************************
+ * Public Types
+ ****************************************************************************/
+
+typedef enum
+{
+ TRACE_TYPE_LTTNG_KERNEL = 0, /* Common Trace Format : Linux Kernel Trace */
+ TRACE_TYPE_GENERIC_CTF = 1, /* Common Trace Format : Generic CTF Trace */
+ TRACE_TYPE_LTTNG_UST = 2, /* Common Trace Format : LTTng UST Trace */
+ TRACE_TYPE_CUSTOM_TEXT = 3, /* Custom Text : TmfGeneric */
+ TRACE_TYPE_CUSTOM_XML = 4, /* Custom XML : Custom XML Log */
+ TRACE_TYPE_ANDROID = 5, /* Custom Format : Android ATrace */
Review comment:
no change?
##########
File path: system/trace/trace.c
##########
@@ -142,10 +142,22 @@ static int trace_cmd_start(int index, int argc, FAR char
**argv,
static int trace_cmd_dump(int index, int argc, FAR char **argv,
int notectlfd)
{
+ trace_dump_t type = TRACE_TYPE_LTTNG_KERNEL;
FAR FILE *out = stdout;
- int ret;
bool changed = false;
bool cont = false;
+ int ret;
+
+ /* Usage: trace dump [-t] <dumptype> */
Review comment:
[-t]->[-l|-a] instead number to help people
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
