pkarashchenko commented on a change in pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r839955675
########## File path: arch/risc-v/include/mode.h ########## @@ -0,0 +1,101 @@ +/**************************************************************************** + * arch/risc-v/include/mode.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __ARCH_RISCV_INCLUDE_MODE_H +#define __ARCH_RISCV_INCLUDE_MODE_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/irq.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#ifdef CONFIG_ARCH_USE_S_MODE + +/* CSR definitions */ + +# define CSR_STATUS sstatus /* Global status register */ Review comment: I just re-read this thread again and think that both authors and reviewers are a bit tired and it is good not to rock the boat and stabilize this PR to get it merged. When I was writing a comment to add `__XSTR()` I was expecting that other macros will be adapted accordingly like: ``` # define CSR_IE __XSTR(sie) /* Interrupt enable register */ CLEAR_CSR(CSR_IE, IE_SIE); #define WRITE_CSR(reg, val) \ ({ \ __asm__ __volatile__("csrw " reg ", %0" :: "rK"(val)); \ }) ``` And stringify is removed from `WRITE_CSR` definition. EDIT 1: But with this approach any `reg` parameter should go thru `__XSTR()` in prior to be passed and that is not user friendly. Let's keep the things like they are now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
