lupyuen opened a new pull request #5907:
URL: https://github.com/apache/incubator-nuttx/pull/5907


   ## Summary
   
   `bl602_spi_cmddata()` implements SPI Cmd/Data `SPI_CMDDATA()` for only 3 LCD 
drivers: ST7735, ST7789 and GC9A01.
   
   This patch removes the check for LCD drivers, so that SPI Cmd/Data will work 
for all LCD drivers.
   
   More details: https://github.com/apache/incubator-nuttx/pull/5898
   
   ## Impact
   
   This change impacts LCD drivers that call `SPI_CMDDATA()`.
   
   Previously `SPI_CMDDATA()` would fail with `ENODEV` for LCD drivers other 
than ST7735, ST7789 and GC9A01.
   
   After patching, `SPI_CMDDATA()` will work correctly with all LCD drivers.
   
   ## Testing
   
   We tested with LVGL and ST7789 on PineCone BL602:
   
   -   [Testing with 
LVGL](https://github.com/lupyuen/st7789-nuttx#run-lvgl-demo)
   
   As for regular SPI Devices that don't require SPI Cmd/Data, we tested 
`CONFIG_SPI_CMDDATA=y` with Semtech SX1262 SPI Transceiver on PineCone BL602:
   
   -   [Testing 
Cmd/Data](https://github.com/lupyuen/incubator-nuttx/releases/tag/release-2022-03-30)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to