xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r837112645
##########
File path: arch/risc-v/src/common/supervisor/riscv_context.S
##########
@@ -0,0 +1,234 @@
+/****************************************************************************
+ * arch/risc-v/src/common/supervisor/riscv_context.S
Review comment:
> I think having the separate folders is more clear.
Yes, the separated folder looks good.
> There are two files that have the same name and different implementations:
>
> * riscv_exception_common.S
> * riscv_vectors.S
>
> Those are selected in Make.defs without reference to the folder. However,
there should not be any more common file names.
>
> I think most of the other files are the .asm functions that are only
needed in S-mode
Ok, but let's keep the difference file name as small as possible, so the
chip's Make.defs could avoid check CONFIG_ARCH_USE_S_MODE as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
