pkarashchenko commented on a change in pull request #5853:
URL: https://github.com/apache/incubator-nuttx/pull/5853#discussion_r835811577



##########
File path: drivers/syslog/vsyslog.c
##########
@@ -130,7 +130,8 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR 
va_list *ap)
 
   if (ret > 0)
     {
-      ret = lib_sprintf(&stream.public, "[%s] ", date_buf);
+      ret = lib_sprintf(&stream.public, "[%s.%06ld] ",
+                        date_buf, ts.tv_nsec / 1000);

Review comment:
       That is understood. I will make more clear example. By default 
`CONFIG_SYSLOG_TIMESTAMP_FORMAT` is set to `"%e/%m/%y %H:%M:%S"`, but what is 
user set's it to `"%e/%m/%y %H:%M"` and do not want to see a seconds (that is 
more theoretical than a practical case and I agree, but still), then it will be 
very strange to see dot and milliseconds value after month.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to