xiaoxiang781216 commented on a change in pull request #1075:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1075#discussion_r827331853
##########
File path: interpreters/lua/Kconfig
##########
@@ -0,0 +1,90 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+menuconfig INTERPRETERS_LUA
+ bool "Lua interpreter support"
+ default n
+ select ARCH_SETJMP_H
+ select LIBC_FLOATINGPOINT
+ select LIBC_LOCALE
+ select LIBM
+ select SYSTEM_SYSTEM
Review comment:
I assume these type of function expose through Lua module, it may better
to implement the wrapper function like this:
```
lua_execute(...)
{
#ifdef CONFIG_SYSTEM_SYTEM
system(...);
#else
report error
#endif
}
```
so, user don't need pay out the cost if they never use it. This trick is
especially useful to some feature which increase a mount of code/data size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
