[GitHub] [incubator-nuttx] Gary-Hobson commented on a change in pull request #5736: driver/uinput: add cross core control function

[GitBox]

Gary-Hobson commented on a change in pull request #5736:
URL: https://github.com/apache/incubator-nuttx/pull/5736#discussion_r826998216



##########
File path: drivers/input/Kconfig
##########
@@ -51,6 +51,13 @@ config INPUT_UINPUT
        ---help---
                Enable support virtual input device driver
 
+config UINPUT_RPMSG
+       bool "Enable uinput rpmsg"
+       depends on INPUT_UINPUT

Review comment:
       RPTUN should be used.
   done~

##########
File path: drivers/input/touchscreen_upper.c
##########
@@ -297,65 +291,49 @@ static int touch_ioctl(FAR struct file *filep, int cmd, 
unsigned long arg)
   return ret;
 }
 
-static int touch_poll(FAR struct file *filep,
-                      struct pollfd *fds, bool setup)
+static int touch_poll(FAR struct file *filep, struct pollfd *fds, bool setup)
 {
-  FAR struct inode *inode = filep->f_inode;
-  FAR struct touch_upperhalf_s *upper = inode->i_private;
+  FAR struct touch_openpriv_s *openpriv = filep->f_priv;
   pollevent_t eventset = 0;
   int ret;
-  int i;
 
-  ret = nxsem_wait(&upper->exclsem);
+  ret = nxsem_wait(&openpriv->locksem);
   if (ret < 0)
     {
       return ret;
     }
 
   if (setup)
     {
-      for (i = 0; i < CONFIG_INPUT_TOUCHSCREEN_NPOLLWAITERS; i++)

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org