jrosberg commented on a change in pull request #5740:
URL: https://github.com/apache/incubator-nuttx/pull/5740#discussion_r825896731
##########
File path: arch/risc-v/src/mpfs/Kconfig
##########
@@ -317,10 +337,151 @@ config MPFS_DMA
---help---
Enable DMA Support. MPFS DMA is Memory-to-Memory only.
-menu "MPFS Others"
+menu "Ethernet MAC configuration"
+ depends on MPFS_ETHMAC
+
+choice
+ prompt "MII Interface mode"
+
+config MPFS_MAC_SGMII
+ bool "SGMII"
+ ---help---
+ Use Ethernet SGMII interface.
+
+config MPFS_MAC_GMII
+ bool "GMII"
+ ---help---
+ Use Ethernet GMII interface.
+endchoice
+
+config MPFS_PHYADDR
+ int "PHY address"
+ default 1
+ ---help---
+ The 5-bit address of the PHY on the board. Default: 1
+
+config MPFS_MAC_NO_BROADCAST
+ bool "Disable Broadcast"
+ default n
+ ---help---
+ Select to disable receipt of broadcast packets.
+
+config MPFS_MAC_AUTONEG
+ bool "Use autonegotiation"
+ default y
+ ---help---
+ Use PHY autonegotiation to determine speed and mode
+
+config MPFS_MAC_DISABLE_1000MBPS
+ bool "Disable Gigabit mode"
+ default n
+ depends on MPFS_MAC_AUTONEG
+ ---help---
+ Select to disable Gigabit speed support.
+ If disabled then autonegotiation don't advertise 1GB mode
+
+config MPFS_PHYINIT
+ bool "Use board phyinit"
+ default n
+ ---help---
+ call mpfs_phy_boardinitialize() on init
+
+if !MPFS_MAC_AUTONEG
+
+config MPFS_MAC_ETHFD
+ bool "Full duplex"
+ default n
+ ---help---
+ If MPFS_MAC_AUTONEG is not defined, then this may be defined to
+ select full duplex mode. Default: half-duplex
+
+choice
+ prompt "MAC Speed"
+ default MPFS_MAC_ETH100MBPS
+ ---help---
+ If autonegotiation is not used, then you must select the fixed
speed
+ of the PHY
+
+config MPFS_MAC_ETH10MBPS
+ bool "10 Mbps"
+ ---help---
+ If MPFS_MAC_AUTONEG is not defined, then this may be defined to
select 10 MBps
+ speed. Default: 100 Mbps
+
+config MPFS_MAC_ETH100MBPS
+ bool "100 Mbps"
+ ---help---
+ If MPFS_MAC_AUTONEG is not defined, then this may be defined to
select 100 MBps
+ speed. Default: 100 Mbps
+
+config MPFS_MAC_ETH1000MBPS
+ bool "1000 Mbps"
+ ---help---
Review comment:
not really. the MPFS_MAC_DISABLE_1000MBPS is for auto negotiate only.
maybe confusing name.
should it be like MPFS_MAC_AUTONEG_DISABLE_1000MBPS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
