pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825469995



##########
File path: arch/xtensa/src/common/xtensa_int_handlers.S
##########
@@ -768,13 +756,13 @@ _xtensa_level6_handler:
 
        /* Restore only level-specific regs (the rest were already restored) */
 
-       l32i    a0, a2, (4 * REG_PS)                    /* Retrieve 
interruptee's PS */
+       l32i    a0, a2, (4 * REG_PS)      /* Retrieve interruptee's PS */
        wsr             a0, EPS_6
-       l32i    a0, a2, (4 * REG_PC)                    /* Retrieve 
interruptee's PC */
+       l32i    a0, a2, (4 * REG_PC)      /* Retrieve interruptee's PC */
        wsr             a0, EPC_6
-       l32i    a0, a2, (4 * REG_A0)                    /* Retrieve 
interruptee's A0 */
-       l32i    sp, a2, (4 * REG_A1)                    /* Remove interrupt 
stack frame */
-       l32i    a2, a2, (4 * REG_A2)                    /* Retrieve 
interruptee's A2 */
+       l32i    a0, a2, (4 * REG_A0)      /* Retrieve interruptee's A0 */
+       l32i    sp, a2, (4 * REG_A1)      /* Retrieve interrupt stack frame */
+       l32i    a2, a2, (4 * REG_A2)      /* Retrieve interruptee's A2 */

Review comment:
       No. The issue is that other lines use tabs for alignment, but you added 
2 spaces per per TAB  on this change and GitHub shows that. If someone will 
open the file with editor that has 4 space per TAB view (for example), then  
formatting will be lost. I just propose to use TABs in this file (actually 
either TABs or spaces, but not a mix) so view will be agnostic to editor 
settings.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to