xiaoxiang781216 commented on a change in pull request #5705:
URL: https://github.com/apache/incubator-nuttx/pull/5705#discussion_r822941672
##########
File path: tools/Config.mk
##########
@@ -149,10 +149,10 @@ ifeq (,$(wildcard $(CUSTOM_BOARD_KPATH)))
else
BOARD_KCONFIG = $(CUSTOM_BOARD_KPATH)
endif
-
-BOARD_COMMON_DIR ?= $(wildcard $(BOARD_DIR)$(DELIM)..$(DELIM)common)
-ifeq ($(BOARD_COMMON_DIR),)
- BOARD_COMMON_DIR = $(wildcard
$(TOPDIR)$(DELIM)boards$(DELIM)$(CONFIG_ARCH)$(DELIM)$(CONFIG_ARCH_CHIP)$(DELIM)common)
+ifeq ($(CONFIG_BOARD_CUSTOM_ARCH_BOARD_COMMON),y)
+ BOARD_COMMON_DIR ?= $(wildcard
$(TOPDIR)$(DELIM)boards$(DELIM)$(CONFIG_ARCH)$(DELIM)$(CONFIG_ARCH_CHIP)$(DELIM)common)
Review comment:
BOARD_COMMON_DIR is used inside Make.defs, if user don't like the
built-in common board, he can ignore this variable directly, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
