pkarashchenko commented on a change in pull request #5476:
URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r822050832
##########
File path: drivers/usbdev/pl2303.c
##########
@@ -830,6 +830,7 @@ static void usbclass_freereq(FAR struct usbdev_ep_s *ep,
static int usbclass_mkstrdesc(uint8_t id, struct usb_strdesc_s *strdesc)
Review comment:
```suggestion
static int usbclass_mkstrdesc(uint8_t id, FAR struct usb_strdesc_s *strdesc)
```
##########
File path: drivers/usbdev/usbmsc_desc.c
##########
@@ -130,6 +130,7 @@ const char g_mscserialstr[] = CONFIG_USBMSC_SERIALSTR;
int usbmsc_mkstrdesc(uint8_t id, struct usb_strdesc_s *strdesc)
{
+ uint8_t *data = (uint8_t *)(strdesc + 1);
Review comment:
```suggestion
FAR uint8_t *data = (FAR uint8_t *)(strdesc + 1);
```
##########
File path: drivers/usbdev/cdcacm_desc.c
##########
@@ -119,7 +119,7 @@ int cdcacm_mkstrdesc(uint8_t id, struct usb_strdesc_s
*strdesc)
{
Review comment:
`int cdcacm_mkstrdesc(uint8_t id, FAR struct usb_strdesc_s *strdesc)`
##########
File path: drivers/usbdev/usbmsc_desc.c
##########
@@ -130,6 +130,7 @@ const char g_mscserialstr[] = CONFIG_USBMSC_SERIALSTR;
int usbmsc_mkstrdesc(uint8_t id, struct usb_strdesc_s *strdesc)
Review comment:
```suggestion
int usbmsc_mkstrdesc(uint8_t id, FAR struct usb_strdesc_s *strdesc)
```
##########
File path: drivers/usbdev/composite_desc.c
##########
@@ -120,6 +120,7 @@ static const struct usb_qualdesc_s g_qualdesc =
int composite_mkstrdesc(uint8_t id, struct usb_strdesc_s *strdesc)
{
+ uint8_t *data = (uint8_t *)(strdesc + 1);
Review comment:
```suggestion
FAR uint8_t *data = (FAR uint8_t *)(strdesc + 1);
```
##########
File path: drivers/usbdev/cdcacm_desc.c
##########
@@ -119,7 +119,7 @@ int cdcacm_mkstrdesc(uint8_t id, struct usb_strdesc_s
*strdesc)
{
#if !defined(CONFIG_CDCACM_COMPOSITE) || defined(CONFIG_CDCACM_NOTIFSTR) || \
defined(CONFIG_CDCACM_DATAIFSTR)
-
+ uint8_t *data = (uint8_t *)(strdesc + 1);
Review comment:
```suggestion
FAR uint8_t *data = (FAR uint8_t *)(strdesc + 1);
```
##########
File path: drivers/usbdev/cdcacm_desc.c
##########
@@ -119,7 +119,7 @@ int cdcacm_mkstrdesc(uint8_t id, struct usb_strdesc_s
*strdesc)
{
#if !defined(CONFIG_CDCACM_COMPOSITE) || defined(CONFIG_CDCACM_NOTIFSTR) || \
defined(CONFIG_CDCACM_DATAIFSTR)
-
+ uint8_t *data = (uint8_t *)(strdesc + 1);
const char *str;
Review comment:
```suggestion
FAR const char *str;
```
##########
File path: drivers/usbdev/pl2303.c
##########
@@ -830,6 +830,7 @@ static void usbclass_freereq(FAR struct usbdev_ep_s *ep,
static int usbclass_mkstrdesc(uint8_t id, struct usb_strdesc_s *strdesc)
{
+ uint8_t *data = (uint8_t *)(strdesc + 1);
Review comment:
```suggestion
FAR uint8_t *data = (FAR uint8_t *)(strdesc + 1);
```
##########
File path: include/nuttx/usb/usb.h
##########
@@ -336,7 +336,8 @@ struct usb_strdesc_s
{
uint8_t len; /* Descriptor length */
uint8_t type; /* Descriptor type */
- uint8_t data[2];
+
+ /* uint8_t data[2]; */
Review comment:
```suggestion
/* uint8_t data[]; */
```
##########
File path: drivers/usbdev/composite_desc.c
##########
@@ -120,6 +120,7 @@ static const struct usb_qualdesc_s g_qualdesc =
int composite_mkstrdesc(uint8_t id, struct usb_strdesc_s *strdesc)
{
+ uint8_t *data = (uint8_t *)(strdesc + 1);
const char *str;
Review comment:
```suggestion
FAR const char *str;
```
##########
File path: drivers/usbdev/dfu.c
##########
@@ -271,7 +271,7 @@ static int usbclass_mkstrdesc(uint8_t id, FAR struct
usb_strdesc_s *strdesc)
return -EINVAL;
}
- strdesc->len = 2 + convert_to_utf16(strdesc->data, str);
+ strdesc->len = 2 + convert_to_utf16((FAR uint8_t *)(strdesc + 1), str);
Review comment:
```suggestion
strdesc->len = sizeof(struct usb_strdesc_s) + convert_to_utf16((FAR
uint8_t *)(strdesc + 1), str);
```
##########
File path: drivers/usbdev/pl2303.c
##########
@@ -830,6 +830,7 @@ static void usbclass_freereq(FAR struct usbdev_ep_s *ep,
static int usbclass_mkstrdesc(uint8_t id, struct usb_strdesc_s *strdesc)
{
+ uint8_t *data = (uint8_t *)(strdesc + 1);
const char *str;
Review comment:
```suggestion
FAR const char *str;
```
##########
File path: drivers/usbdev/composite_desc.c
##########
@@ -120,6 +120,7 @@ static const struct usb_qualdesc_s g_qualdesc =
int composite_mkstrdesc(uint8_t id, struct usb_strdesc_s *strdesc)
Review comment:
```suggestion
int composite_mkstrdesc(uint8_t id, FAR struct usb_strdesc_s *strdesc)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
