pkarashchenko commented on a change in pull request #5476:
URL: https://github.com/apache/incubator-nuttx/pull/5476#discussion_r821741221
##########
File path: include/nuttx/usb/usb.h
##########
@@ -336,7 +336,7 @@ struct usb_strdesc_s
{
uint8_t len; /* Descriptor length */
uint8_t type; /* Descriptor type */
- uint8_t data[2];
+ uint8_t data[];
Review comment:
I think this is C99
##########
File path: fs/fat/Kconfig
##########
@@ -43,7 +43,7 @@ config FAT_LFN
config FAT_MAXFNAME
int "FAT maximum file name size"
depends on FAT_LFN
- default 32
+ default NAME_MAX
Review comment:
Should be update
```
config NAME_MAX
int "Maximum size of a file name"
default 32
---help---
The maximum size of a file name.
```
and add range?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
