gustavonihei commented on pull request #929: URL: https://github.com/apache/incubator-nuttx-apps/pull/929#issuecomment-1056941297
> Hi Folks, > > This change of feelings is that create bad projects. I invested a lot of time to put things in the correct way and, after weeks, now, it is about feelings. Sorry, but this is very disrespectful. > I understand that you invested time in this PR and that you may feel it is being undervalued. This PR has been open for months, but reviewed just by a single person (me). My feelings about moving the examples to the `examples` folder should not be new to you @nandojve, as we've discussed several times before, so on my side there is no "change of feelings". If I really agreed to this, I would have already done this way from the very beginning. I still feel that the examples from a given library should be placed in the same level. Even so, I haven't complained about this in this PR. My expectation was to see if the other developers were OK with it, without adding any bias. The points I raised on this PR is to prevent further deviations from the project structure, such as the naming of the Kconfig options. > If people from NuttX detected a issue about where examples should be added, that should be documented (no more feelings), that it. Since the issue was detected in this PR, and PR was complete reworked to be as requested, at least, you folks should respect the work done and approve it. I am responsible for the code I approve to be merged to the project's codebase. And so far I am still not confident in doing so, according to the reason I stated on the previous message. Let's wait on the feedback from others. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
