pkarashchenko commented on pull request #5625:
URL: https://github.com/apache/incubator-nuttx/pull/5625#issuecomment-1053605271


   Currently `ajoy_enable` is called from `ajoy_sample` that is called from 
`ajoy_interrupt`. Also `ajoy_enable` is called from `ajoy_ioctl` for example. 
You are trying to fix resource protection in 
https://github.com/apache/incubator-nuttx/pull/5204 so currently the timing 
might lead to interrupt fire during `opriv->ao_pollevents` modification in 
`ajoy_ioctl`.
   I really think that your change are correct, however I also think that there 
still is some dependency on 
`https://github.com/apache/incubator-nuttx/pull/5204`. It is not sequential 
dependency, I agree.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to