AlanRosenthal commented on a change in pull request #5176: URL: https://github.com/apache/incubator-nuttx/pull/5176#discussion_r779149800
########## File path: tools/Unix.mk ########## @@ -589,36 +579,43 @@ pass2dep: context tools/mkdeps$(HOSTEXEEXT) tools/cnvwindeps$(HOSTEXEEXT) config: $(Q) $(MAKE) clean_context + $(Q) $(MAKE) context $(Q) $(MAKE) apps_preconfig $(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf Kconfig oldconfig: $(Q) $(MAKE) clean_context + $(Q) $(MAKE) context $(Q) $(MAKE) apps_preconfig $(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf --oldconfig Kconfig olddefconfig: $(Q) $(MAKE) clean_context + $(Q) $(MAKE) context $(Q) $(MAKE) apps_preconfig $(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf --olddefconfig Kconfig menuconfig: $(Q) $(MAKE) clean_context + $(Q) $(MAKE) context Review comment: makefile rules are indented with tabs, and makefiles lists are intended with spaces -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org